From: Vadzim Dambrouski <pftbest@gmail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v2 2/2] arm: fix compile warnings when semihosting is enabled on ARMv7M target.
Date: Mon, 19 Oct 2015 13:00:32 +0300 [thread overview]
Message-ID: <5624BF40.3000408@gmail.com> (raw)
In-Reply-To: <20151019080601.0e906321@lilith>
On 19.10.2015 09:06, Albert ARIBAUD wrote:
> Hello Vadzim,
>
> On Mon, 19 Oct 2015 00:13:29 +0300, Vadzim Dambrouski
> <pftbest@gmail.com> wrote:
>> Signed-off-by: Vadzim Dambrouski <pftbest@gmail.com>
>> ---
>>
>> arch/arm/lib/semihosting.c | 4 ++--
>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/arch/arm/lib/semihosting.c b/arch/arm/lib/semihosting.c
>> index ed5e8e4..6541cb4 100644
>> --- a/arch/arm/lib/semihosting.c
>> +++ b/arch/arm/lib/semihosting.c
>> @@ -92,7 +92,7 @@ static long smh_read(long fd, void *memp, size_t len)
>> size_t len;
>> } read;
>>
>> - debug("%s: fd %ld, memp %p, len %lu\n", __func__, fd, memp, len);
>> + debug("%s: fd %ld, memp %p, len %lu\n", __func__, fd, memp, (ulong)len);
>>
>> read.fd = fd;
>> read.memp = memp;
>> @@ -107,7 +107,7 @@ static long smh_read(long fd, void *memp, size_t len)
>> * with an error message.
>> */
>> printf("%s: ERROR ret %ld, fd %ld, len %lu memp %p\n",
>> - __func__, ret, fd, len, memp);
>> + __func__, ret, fd, (ulong)len, memp);
>> return -1;
>> }
>
> len is a size_t; it should not be force-converted into a long, it
> should be printed using a 'z' qualifier.
>
> Amicalement,
>
Well, you are right, I'll send another revision of this patch set.
Thank you for all your assistance.
Regards,
Vadzim Dambrouski
next prev parent reply other threads:[~2015-10-19 10:00 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-18 21:13 [U-Boot] [PATCH v2 1/2] arm: add support for semihosting for ARMv7M targets Vadzim Dambrouski
2015-10-18 21:13 ` [U-Boot] [PATCH v2 2/2] arm: fix compile warnings when semihosting is enabled on ARMv7M target Vadzim Dambrouski
2015-10-19 6:06 ` Albert ARIBAUD
2015-10-19 10:00 ` Vadzim Dambrouski [this message]
2015-10-19 6:00 ` [U-Boot] [PATCH v2 1/2] arm: add support for semihosting for ARMv7M targets Albert ARIBAUD
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5624BF40.3000408@gmail.com \
--to=pftbest@gmail.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox