[U-Boot] [PATCH] arm: sunxi: Add icnova-a20-swac defconfig and dts file

Stefan Roese
2015-10-19T11:53:01Z

Hi Hans,

On 19.10.2015 13:44, Hans de Goede wrote:

<snip>

>>>>> diff --git a/arch/arm/dts/sun7i-a20-icnova-a20-swac.dts
>>>>> b/arch/arm/dts/sun7i-a20-icnova-a20-swac.dts
>>>>> new file mode 100644
>>>>
>>>> Please submit this file also to the upstream kernel.
>>>
>>> Yes. The name of the DT especially doesn't really make sense. The
>>> "SWAC" name isn't referenced anywhere, the module cannot be used
>>> alone, and there's a single combination available (A20 SODIMM +
>>> ADB4006)
>>
>> At least one other combination is available. A custom board from SWAC
>> equipped with the SoM. What is the preferred method to support SoM's
>> with multiple baseboards? Something like:
>>
>> sun7i-a20-icnova.dtsi
>> sun7i-a20-icnova-adb4006.dts
>> sun7i-a20-icnova-swac.dts
>>
>> ?
>>
>>>>
>>>>> index 0000000..773fb6f
>>>>> --- /dev/null
>>>>> +++ b/arch/arm/dts/sun7i-a20-icnova-a20-swac.dts
>>>>> @@ -0,0 +1,177 @@
>>>>> +/*
>>>>> + * Copyright 2013 Maxime Ripard
>>>>> + *
>>>>> + * Maxime Ripard <maxime.ripard@free-electrons.com>
>>>
>>> And I'm *not* the copyright owner here.
>>
>> Okay. Hans, do you want me to change this (and potential other
>> changes as well - see file naming above) via a follow-up patch
>> once its available in mainline U-Boot?
>
> Actually I would prefer to get this right in one go, esp. the
> filename bits, having u-boot and the kernel disagreeing on the
> dtb filename is no good. So I plan to remove this version of
> the patch from u-boot-sunxi/next for now. Once you and Maxime
> agree on a dts / dtb filename please submit a new version and
> I'll merge that one instead.

Sure. Lets do it this way.

Thanks,
Stefan