From mboxrd@z Thu Jan  1 00:00:00 1970
From: Richard Weinberger <richard@nod.at>
Date: Mon, 19 Oct 2015 22:22:17 +0200
Subject: [U-Boot] Porting UBI fixes (specially fastmap's) to U-Boot
In-Reply-To: <CAAEAJfCq=qzGX5fqaiq-K4gA-L3b_tdAvqB_SZKsKag-m4nCrQ@mail.gmail.com>
References: <CAAEAJfAXakQki=XLaOAyQhHbYH_s6fnZmvvTJ9W5b7uqXURLzQ@mail.gmail.com>
 <561666CB.8070908@denx.de> <56166992.2020004@nod.at>
 <561683A5.6060000@denx.de>
 <CAAEAJfD9Ur_WEQpnFxjnLgNy4XgTRjKd=fR-rJ2=WGyw7Yg6Wg@mail.gmail.com>
 <56173C31.6010202@denx.de> <5617B37D.5050403@denx.de>
 <CAAEAJfDfrYA6Z9HDAVNnZy8L93PPX5a_LHzrPDZa7YmE+5bgGw@mail.gmail.com>
 <56247CFA.1010105@denx.de>
 <CAAEAJfCq=qzGX5fqaiq-K4gA-L3b_tdAvqB_SZKsKag-m4nCrQ@mail.gmail.com>
Message-ID: <562550F9.7020009@nod.at>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Am 19.10.2015 um 15:47 schrieb Ezequiel Garcia:
> After some further investigation, printing the counters as Richard suggested
> I found it was a bug on my side :-( The Linux partition and the U-Boot partition
> had different size (i.e. PEB count) and so Fastmap complained :-(
> 
> We trimmed the Linux partition size, and forgot to change U-Boot's
> (or thought it wouldn't matter).
> 
> Sorry for the noise guys!

Good to know. :)

Let me find a way to detect and report this kind of user error
better.
The WARN_ON() is only meant for bad internal errors.

> Linux WARN_xxx macros return a value, and so can be used inside
> if statements. U-Boot on the other side, just prints a warning:
> 
> #define WARN_ON(x) if (x) {printf("WARNING in %s line %d\n" \
>                                   , __FILE__, __LINE__); }
> 
> AFAICS, the above ifndef __UBOOT__ is needed, unless you fix
> your WARN_ON in U-Boot.

+1

Thanks,
//richard