public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Stephen Warren <swarren@wwwdotorg.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v3] Tegra: T210: Add QSPI driver
Date: Wed, 21 Oct 2015 11:18:41 -0600	[thread overview]
Message-ID: <5627C8F1.4020606@wwwdotorg.org> (raw)
In-Reply-To: <11398fa64ad549b48a942725aac8a296@HQMAIL103.nvidia.com>

On 10/21/2015 10:58 AM, Tom Warren wrote:
>Stephen Warren wrote atWednesday, October 21, 2015 9:52 AM:
>> On 10/20/2015 03:31 PM, Tom Warren wrote:
>>> This is the normal Tegra SPI driver modified to work with the QSPI
>>> controller in Tegra210. It does not do 2x/4x transfers or any other
>>> QSPI protocol.
>>>
>>> Author: Yen Lin <yelin@nvidia.com>
>>> Signed-off-by: Yen Lin <yelin@nvidia.com>
>>> Signed-off-by: Tom Warren <twarren@nvidia.com>
>>> ---
>>> Changes in v2:
>>> - Drop defconfig and pinmux files, this is a driver-only patch.
>>> - If/when pinmux tables have been updated for P2371/P2571, another
>>> - patch will be sent to enable the QSPI driver on those boards.
>>> Changes in v3:
>>> - removed status reg write/clear in claim_bus(), done in xfer()
>>
>> The code looks OK, but we need the binding document written and approved before we commit to the driver, I think.
 >
> OK. As I asked in the V2 review comments, are you going to write the binding doc, or if not, who do you think should/could do it? I don't know enough to attempt it.

Sorry, I didn't notice that comment in your email, since the quoting 
style wasn't standard (indent with >).

It's the responsibility of the person who implements the driver for the 
device. Writing binding docs is now unfortunately part and parcel of 
almost any driver work.

This device is probably similar enough to the other Tegra SPI 
controllers that you can likely cut/paste most of the doc, and simply 
adjust the names and resource definitions as appropriate for this HW module.

  reply	other threads:[~2015-10-21 17:18 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-10-20 21:31 [U-Boot] [PATCH v3] Tegra: T210: Add QSPI driver Tom Warren
2015-10-21 16:52 ` Stephen Warren
2015-10-21 16:58   ` Tom Warren
2015-10-21 17:18     ` Stephen Warren [this message]
2015-10-22 12:23 ` Jagan Teki
2015-10-22 16:51   ` Tom Warren
2015-10-22 22:48     ` Yen Lin
2015-10-25  3:14       ` Jagan Teki
2015-10-26 20:58         ` Tom Warren

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5627C8F1.4020606@wwwdotorg.org \
    --to=swarren@wwwdotorg.org \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox