public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Stephen Warren <swarren@wwwdotorg.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 2/2] ARM: tegra: enable PCI support of p2371-2180
Date: Wed, 21 Oct 2015 17:10:30 -0600	[thread overview]
Message-ID: <56281B66.1040301@wwwdotorg.org> (raw)
In-Reply-To: <4f09015b4d1341f78fc63decfb0f5769@HQMAIL103.nvidia.com>

On 10/21/2015 05:03 PM, Tom Warren wrote:
> Stephen,
>
>> -----Original Message-----
>> From: Stephen Warren [mailto:swarren at wwwdotorg.org]
>> Sent: Monday, October 05, 2015 4:03 PM
>> To: u-boot at lists.denx.de; Simon Glass <sjg@chromium.org>; Tom Warren
>> <TWarren@nvidia.com>; Stephen Warren <swarren@nvidia.com>
>> Cc: Thierry Reding <treding@nvidia.com>
>> Subject: [PATCH 2/2] ARM: tegra: enable PCI support of p2371-2180
>>
>> From: Stephen Warren <swarren@nvidia.com>
>>
>> p2371-2180 has two PCI ports; a regular x4 slot and a x1 M.2 slot. This patch
>> adds the relevant DT to enable the PCI controller and configure the XUSB padctl
>> pin muxing, and code to turn on the PCI power and enable PCI features in U-
>> Boot. I have only tested the x4 slot.
>>
>> Signed-off-by: Stephen Warren <swarren@nvidia.com>
>
> This breaks the P2371-2180 build with this error:
>
> drivers/net/rtl8169.c: In function 'rtl_recv':
> drivers/net/rtl8169.c:584:25: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast]
>    return rtl_recv_common((pci_dev_t)dev->priv, dev->iobase, NULL);
>                           ^
> drivers/net/rtl8169.c: In function 'rtl_send':
> drivers/net/rtl8169.c:669:25: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast]
>    return rtl_send_common((pci_dev_t)dev->priv, dev->iobase, packet,
>                           ^
> drivers/net/rtl8169.c: In function 'rtl_reset':
> drivers/net/rtl8169.c:849:23: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast]
>    rtl8169_common_start((pci_dev_t)dev->priv, dev->enetaddr);
>
> I've taken my current u-boot-tegra/master, rebased against u-boot/master, added your armv8 NONCACHED_MEMORY patchset, then your PLLE, XUSB and PCI patchsets. Here are the top commits:
...

You're missing the following two:

net: rtl8169: Build warning fixes for 64-bit
fdt: fix fdtdec_get_pci_addr() for CONFIG_PHYS_64BIT

(see note below --- in patch 1)

I think everything else required is in your list.

  reply	other threads:[~2015-10-21 23:10 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-10-05 23:02 [U-Boot] [PATCH 1/2] ARM: tegra: add PCI to Tegra210 SoC DT Stephen Warren
2015-10-05 23:02 ` [U-Boot] [PATCH 2/2] ARM: tegra: enable PCI support of p2371-2180 Stephen Warren
2015-10-21 23:03   ` Tom Warren
2015-10-21 23:10     ` Stephen Warren [this message]
2015-10-21 23:24       ` Tom Warren
2015-10-22  1:51         ` Stephen Warren
2015-10-21 16:42 ` [U-Boot] [PATCH 1/2] ARM: tegra: add PCI to Tegra210 SoC DT Stephen Warren

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=56281B66.1040301@wwwdotorg.org \
    --to=swarren@wwwdotorg.org \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox