From mboxrd@z Thu Jan  1 00:00:00 1970
From: Stephen Warren <swarren@wwwdotorg.org>
Date: Wed, 21 Oct 2015 19:51:23 -0600
Subject: [U-Boot] [PATCH 2/2] ARM: tegra: enable PCI support of
	p2371-2180
In-Reply-To: <aa5a3d6c55b9497ab0085fa7f5e5b012@HQMAIL103.nvidia.com>
References: <1444086160-30298-1-git-send-email-swarren@wwwdotorg.org>
 <1444086160-30298-2-git-send-email-swarren@wwwdotorg.org>
 <4f09015b4d1341f78fc63decfb0f5769@HQMAIL103.nvidia.com>
 <56281B66.1040301@wwwdotorg.org>
 <aa5a3d6c55b9497ab0085fa7f5e5b012@HQMAIL103.nvidia.com>
Message-ID: <5628411B.1070500@wwwdotorg.org>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

On 10/21/2015 05:24 PM, Tom Warren wrote:
>Stephen Warren wrote at Wednesday, October 21, 2015 4:11 PM:
>> On 10/21/2015 05:03 PM, Tom Warren wrote:
>>> Stephen,
>>>
>>>Stephen Warren wrote at Monday, October 05, 2015 4:03 PM:
>>>> p2371-2180 has two PCI ports; a regular x4 slot and a x1 M.2 slot.
>>>> This patch adds the relevant DT to enable the PCI controller and
>>>> configure the XUSB padctl pin muxing, and code to turn on the PCI
>>>> power and enable PCI features in U- Boot. I have only tested the x4 slot.
>>>>
>>>> Signed-off-by: Stephen Warren <swarren@nvidia.com>
>>>
>>> This breaks the P2371-2180 build with this error:
>>>
>>> drivers/net/rtl8169.c: In function 'rtl_recv':
>>> drivers/net/rtl8169.c:584:25: warning: cast from pointer to integer of
>> different size [-Wpointer-to-int-cast]
>>>    return rtl_recv_common((pci_dev_t)dev->priv, dev->iobase, NULL);
>>>                           ^
>>> drivers/net/rtl8169.c: In function 'rtl_send':
>>> drivers/net/rtl8169.c:669:25: warning: cast from pointer to integer of
>> different size [-Wpointer-to-int-cast]
>>>    return rtl_send_common((pci_dev_t)dev->priv, dev->iobase, packet,
>>>                           ^
>>> drivers/net/rtl8169.c: In function 'rtl_reset':
>>> drivers/net/rtl8169.c:849:23: warning: cast from pointer to integer of
>> different size [-Wpointer-to-int-cast]
>>>    rtl8169_common_start((pci_dev_t)dev->priv, dev->enetaddr);
>>>
>>> I've taken my current u-boot-tegra/master, rebased against u-boot/master,
>> added your armv8 NONCACHED_MEMORY patchset, then your PLLE, XUSB and
>> PCI patchsets. Here are the top commits:
>> ...
>>
>> You're missing the following two:
>>
>> net: rtl8169: Build warning fixes for 64-bit
>> fdt: fix fdtdec_get_pci_addr() for CONFIG_PHYS_64BIT
>
> Actually the 'net: rtl8169' patch is in there (brought in from my rebase w/u-boot/master this morning), but the 'fix fdtdec_get_pci_addr' patch isn't. Looks like it is assigned to Simon in Patchwork, and hasn't been applied yet (as of when I pulled down u-boot/master several hours ago). I'll check again, and apply it myself to get the build working if needed so I can do some testing.

You're probably seeing this one from Thierry:
744152f8cf42 net: rtl8169: Build warning fixes for 64-bit

Some additional warnings were introduced by some other commit since he
wrote that. Unfortunately it looks like I the fix I wrote for that used
the same subject line; sorry about that. My patch is:

http://patchwork.ozlabs.org/patch/525854/
net: rtl8169: Build warning fixes for 64-bit