* [U-Boot] [PATCH] dm: keystone: serial: Add driver model support
@ 2015-09-19 9:17 Lokesh Vutla
2015-09-19 21:53 ` Simon Glass
2015-10-23 3:24 ` Lokesh Vutla
0 siblings, 2 replies; 4+ messages in thread
From: Lokesh Vutla @ 2015-09-19 9:17 UTC (permalink / raw)
To: u-boot
Add driver model support for keystone serial driver.
Signed-off-by: Lokesh Vutla <lokeshvutla@ti.com>
---
drivers/serial/Makefile | 1 +
drivers/serial/serial_keystone.c | 48 ++++++++++++++++++++++++++++++++++++++++
2 files changed, 49 insertions(+)
create mode 100644 drivers/serial/serial_keystone.c
diff --git a/drivers/serial/Makefile b/drivers/serial/Makefile
index 869ea7b..1818c7c 100644
--- a/drivers/serial/Makefile
+++ b/drivers/serial/Makefile
@@ -25,6 +25,7 @@ obj-$(CONFIG_EFI_APP) += serial_efi.o
obj-$(CONFIG_LPC32XX_HSUART) += lpc32xx_hsuart.o
obj-$(CONFIG_MCFUART) += mcfuart.o
obj-$(CONFIG_OPENCORES_YANU) += opencores_yanu.o
+obj-$(CONFIG_KEYSTONE_SERIAL) += serial_keystone.o
obj-$(CONFIG_SYS_NS16550) += ns16550.o
obj-$(CONFIG_S5P) += serial_s5p.o
obj-$(CONFIG_IMX_SERIAL) += serial_imx.o
diff --git a/drivers/serial/serial_keystone.c b/drivers/serial/serial_keystone.c
new file mode 100644
index 0000000..7b5ab6c
--- /dev/null
+++ b/drivers/serial/serial_keystone.c
@@ -0,0 +1,48 @@
+/*
+ * Copyright (c) 2015 Texas Instruments, <www.ti.com>
+ *
+ * SPDX-License-Identifier: GPL-2.0+
+ */
+
+#include <common.h>
+#include <dm.h>
+#include <fdtdec.h>
+#include <ns16550.h>
+#include <serial.h>
+#include <asm/arch/clock.h>
+
+DECLARE_GLOBAL_DATA_PTR;
+
+#if CONFIG_IS_ENABLED(OF_CONTROL)
+static const struct udevice_id keystone_serial_ids[] = {
+ { .compatible = "ti,keystone-uart" },
+ { .compatible = "ns16550a" },
+ { }
+};
+
+static int keystone_serial_ofdata_to_platdata(struct udevice *dev)
+{
+ struct ns16550_platdata *plat = dev_get_platdata(dev);
+ int ret;
+
+ ret = ns16550_serial_ofdata_to_platdata(dev);
+ if (ret)
+ return ret;
+ plat->clock = CONFIG_SYS_NS16550_CLK;
+ return 0;
+}
+#endif
+
+U_BOOT_DRIVER(serial_keystone_ns16550) = {
+ .name = "serial_keystone",
+ .id = UCLASS_SERIAL,
+#if CONFIG_IS_ENABLED(OF_CONTROL)
+ .of_match = of_match_ptr(keystone_serial_ids),
+ .ofdata_to_platdata = of_match_ptr(keystone_serial_ofdata_to_platdata),
+ .platdata_auto_alloc_size = sizeof(struct ns16550_platdata),
+#endif
+ .priv_auto_alloc_size = sizeof(struct NS16550),
+ .probe = ns16550_serial_probe,
+ .ops = &ns16550_serial_ops,
+ .flags = DM_FLAG_PRE_RELOC,
+};
--
2.1.4
^ permalink raw reply related [flat|nested] 4+ messages in thread* [U-Boot] [PATCH] dm: keystone: serial: Add driver model support
2015-09-19 9:17 [U-Boot] [PATCH] dm: keystone: serial: Add driver model support Lokesh Vutla
@ 2015-09-19 21:53 ` Simon Glass
2015-10-23 3:24 ` Lokesh Vutla
1 sibling, 0 replies; 4+ messages in thread
From: Simon Glass @ 2015-09-19 21:53 UTC (permalink / raw)
To: u-boot
Hi Lokesh,
On 19 September 2015 at 03:17, Lokesh Vutla <lokeshvutla@ti.com> wrote:
> Add driver model support for keystone serial driver.
>
> Signed-off-by: Lokesh Vutla <lokeshvutla@ti.com>
> ---
> drivers/serial/Makefile | 1 +
> drivers/serial/serial_keystone.c | 48 ++++++++++++++++++++++++++++++++++++++++
> 2 files changed, 49 insertions(+)
> create mode 100644 drivers/serial/serial_keystone.c
Acked-by: Simon Glass <sjg@chromium.org>
If we could use the new binding with clock-frequency in it some of
these drivers could be removed.
Regards,
Simon
^ permalink raw reply [flat|nested] 4+ messages in thread
* [U-Boot] [PATCH] dm: keystone: serial: Add driver model support
2015-09-19 9:17 [U-Boot] [PATCH] dm: keystone: serial: Add driver model support Lokesh Vutla
2015-09-19 21:53 ` Simon Glass
@ 2015-10-23 3:24 ` Lokesh Vutla
2015-10-23 14:54 ` Tom Rini
1 sibling, 1 reply; 4+ messages in thread
From: Lokesh Vutla @ 2015-10-23 3:24 UTC (permalink / raw)
To: u-boot
Hi Tom,
On Saturday 19 September 2015 02:47 PM, Lokesh Vutla wrote:
> Add driver model support for keystone serial driver.
I guess you missed this patch. This has to be applied for console to
come up on keystone2 devices.
Thanks and regards,
Lokesh
>
> Signed-off-by: Lokesh Vutla <lokeshvutla@ti.com>
> ---
> drivers/serial/Makefile | 1 +
> drivers/serial/serial_keystone.c | 48 ++++++++++++++++++++++++++++++++++++++++
> 2 files changed, 49 insertions(+)
> create mode 100644 drivers/serial/serial_keystone.c
>
> diff --git a/drivers/serial/Makefile b/drivers/serial/Makefile
> index 869ea7b..1818c7c 100644
> --- a/drivers/serial/Makefile
> +++ b/drivers/serial/Makefile
> @@ -25,6 +25,7 @@ obj-$(CONFIG_EFI_APP) += serial_efi.o
> obj-$(CONFIG_LPC32XX_HSUART) += lpc32xx_hsuart.o
> obj-$(CONFIG_MCFUART) += mcfuart.o
> obj-$(CONFIG_OPENCORES_YANU) += opencores_yanu.o
> +obj-$(CONFIG_KEYSTONE_SERIAL) += serial_keystone.o
> obj-$(CONFIG_SYS_NS16550) += ns16550.o
> obj-$(CONFIG_S5P) += serial_s5p.o
> obj-$(CONFIG_IMX_SERIAL) += serial_imx.o
> diff --git a/drivers/serial/serial_keystone.c b/drivers/serial/serial_keystone.c
> new file mode 100644
> index 0000000..7b5ab6c
> --- /dev/null
> +++ b/drivers/serial/serial_keystone.c
> @@ -0,0 +1,48 @@
> +/*
> + * Copyright (c) 2015 Texas Instruments, <www.ti.com>
> + *
> + * SPDX-License-Identifier: GPL-2.0+
> + */
> +
> +#include <common.h>
> +#include <dm.h>
> +#include <fdtdec.h>
> +#include <ns16550.h>
> +#include <serial.h>
> +#include <asm/arch/clock.h>
> +
> +DECLARE_GLOBAL_DATA_PTR;
> +
> +#if CONFIG_IS_ENABLED(OF_CONTROL)
> +static const struct udevice_id keystone_serial_ids[] = {
> + { .compatible = "ti,keystone-uart" },
> + { .compatible = "ns16550a" },
> + { }
> +};
> +
> +static int keystone_serial_ofdata_to_platdata(struct udevice *dev)
> +{
> + struct ns16550_platdata *plat = dev_get_platdata(dev);
> + int ret;
> +
> + ret = ns16550_serial_ofdata_to_platdata(dev);
> + if (ret)
> + return ret;
> + plat->clock = CONFIG_SYS_NS16550_CLK;
> + return 0;
> +}
> +#endif
> +
> +U_BOOT_DRIVER(serial_keystone_ns16550) = {
> + .name = "serial_keystone",
> + .id = UCLASS_SERIAL,
> +#if CONFIG_IS_ENABLED(OF_CONTROL)
> + .of_match = of_match_ptr(keystone_serial_ids),
> + .ofdata_to_platdata = of_match_ptr(keystone_serial_ofdata_to_platdata),
> + .platdata_auto_alloc_size = sizeof(struct ns16550_platdata),
> +#endif
> + .priv_auto_alloc_size = sizeof(struct NS16550),
> + .probe = ns16550_serial_probe,
> + .ops = &ns16550_serial_ops,
> + .flags = DM_FLAG_PRE_RELOC,
> +};
>
^ permalink raw reply [flat|nested] 4+ messages in thread* [U-Boot] [PATCH] dm: keystone: serial: Add driver model support
2015-10-23 3:24 ` Lokesh Vutla
@ 2015-10-23 14:54 ` Tom Rini
0 siblings, 0 replies; 4+ messages in thread
From: Tom Rini @ 2015-10-23 14:54 UTC (permalink / raw)
To: u-boot
On Fri, Oct 23, 2015 at 08:54:02AM +0530, Lokesh Vutla wrote:
> Hi Tom,
>
> On Saturday 19 September 2015 02:47 PM, Lokesh Vutla wrote:
> > Add driver model support for keystone serial driver.
>
> I guess you missed this patch. This has to be applied for console to
> come up on keystone2 devices.
Ooops, thanks!
Applied to u-boot/master.
>
> Thanks and regards,
> Lokesh
>
> >
> > Signed-off-by: Lokesh Vutla <lokeshvutla@ti.com>
> > ---
> > drivers/serial/Makefile | 1 +
> > drivers/serial/serial_keystone.c | 48 ++++++++++++++++++++++++++++++++++++++++
> > 2 files changed, 49 insertions(+)
> > create mode 100644 drivers/serial/serial_keystone.c
> >
> > diff --git a/drivers/serial/Makefile b/drivers/serial/Makefile
> > index 869ea7b..1818c7c 100644
> > --- a/drivers/serial/Makefile
> > +++ b/drivers/serial/Makefile
> > @@ -25,6 +25,7 @@ obj-$(CONFIG_EFI_APP) += serial_efi.o
> > obj-$(CONFIG_LPC32XX_HSUART) += lpc32xx_hsuart.o
> > obj-$(CONFIG_MCFUART) += mcfuart.o
> > obj-$(CONFIG_OPENCORES_YANU) += opencores_yanu.o
> > +obj-$(CONFIG_KEYSTONE_SERIAL) += serial_keystone.o
> > obj-$(CONFIG_SYS_NS16550) += ns16550.o
> > obj-$(CONFIG_S5P) += serial_s5p.o
> > obj-$(CONFIG_IMX_SERIAL) += serial_imx.o
> > diff --git a/drivers/serial/serial_keystone.c b/drivers/serial/serial_keystone.c
> > new file mode 100644
> > index 0000000..7b5ab6c
> > --- /dev/null
> > +++ b/drivers/serial/serial_keystone.c
> > @@ -0,0 +1,48 @@
> > +/*
> > + * Copyright (c) 2015 Texas Instruments, <www.ti.com>
> > + *
> > + * SPDX-License-Identifier: GPL-2.0+
> > + */
> > +
> > +#include <common.h>
> > +#include <dm.h>
> > +#include <fdtdec.h>
> > +#include <ns16550.h>
> > +#include <serial.h>
> > +#include <asm/arch/clock.h>
> > +
> > +DECLARE_GLOBAL_DATA_PTR;
> > +
> > +#if CONFIG_IS_ENABLED(OF_CONTROL)
> > +static const struct udevice_id keystone_serial_ids[] = {
> > + { .compatible = "ti,keystone-uart" },
> > + { .compatible = "ns16550a" },
> > + { }
> > +};
> > +
> > +static int keystone_serial_ofdata_to_platdata(struct udevice *dev)
> > +{
> > + struct ns16550_platdata *plat = dev_get_platdata(dev);
> > + int ret;
> > +
> > + ret = ns16550_serial_ofdata_to_platdata(dev);
> > + if (ret)
> > + return ret;
> > + plat->clock = CONFIG_SYS_NS16550_CLK;
> > + return 0;
> > +}
> > +#endif
> > +
> > +U_BOOT_DRIVER(serial_keystone_ns16550) = {
> > + .name = "serial_keystone",
> > + .id = UCLASS_SERIAL,
> > +#if CONFIG_IS_ENABLED(OF_CONTROL)
> > + .of_match = of_match_ptr(keystone_serial_ids),
> > + .ofdata_to_platdata = of_match_ptr(keystone_serial_ofdata_to_platdata),
> > + .platdata_auto_alloc_size = sizeof(struct ns16550_platdata),
> > +#endif
> > + .priv_auto_alloc_size = sizeof(struct NS16550),
> > + .probe = ns16550_serial_probe,
> > + .ops = &ns16550_serial_ops,
> > + .flags = DM_FLAG_PRE_RELOC,
> > +};
> >
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20151023/29c5517a/attachment.sig>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2015-10-23 14:54 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-09-19 9:17 [U-Boot] [PATCH] dm: keystone: serial: Add driver model support Lokesh Vutla
2015-09-19 21:53 ` Simon Glass
2015-10-23 3:24 ` Lokesh Vutla
2015-10-23 14:54 ` Tom Rini
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox