From: Igor Grinberg <grinberg@compulab.co.il>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 3/5] splash_source: add support for filesystem formatted usb
Date: Fri, 23 Oct 2015 16:12:01 +0300 [thread overview]
Message-ID: <562A3221.5070804@compulab.co.il> (raw)
In-Reply-To: <20151023102338.GC11008@skynet>
On 10/23/15 13:23, Nikita Kiryanov wrote:
> On Wed, Oct 21, 2015 at 04:01:46PM +0300, Igor Grinberg wrote:
>> On 08/30/15 11:42, Nikita Kiryanov wrote:
>>> Add support for loading splash image from USB drive formatted with a
>>> filesystem.
>>>
>>> Cc: Igor Grinberg <grinberg@compulab.co.il>
>>> Cc: Tom Rini <trini@konsulko.com>
>>> Signed-off-by: Nikita Kiryanov <nikita@compulab.co.il>
>>
>> [...]
>>
>>> +#ifdef CONFIG_USB_STORAGE
>>> + if (location->storage == SPLASH_STORAGE_USB) {
>>> + usb_init();
>>> + usb_stor_scan(1);
>>> + }
>>> +#endif
>>
>> Can we use IS_ENABLED() stuff here instead?
>
> IS_ENABLED() does not prevent compile errors, only closes off certain
> code paths.
Ok. Any other ways to not have that ifdefferry inside functions?
--
Regards,
Igor.
next prev parent reply other threads:[~2015-10-23 13:12 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-30 8:42 [U-Boot] [PATCH 0/5] Add support for additional splash screen locations Nikita Kiryanov
2015-08-30 8:42 ` [U-Boot] [PATCH 1/5] splash_source: rename *_read() to *_read_raw() Nikita Kiryanov
2015-10-21 12:14 ` Igor Grinberg
2015-08-30 8:42 ` [U-Boot] [PATCH 2/5] splash_source: add support for filesystem formatted mmc Nikita Kiryanov
2015-10-21 12:25 ` Igor Grinberg
2015-10-23 10:51 ` Nikita Kiryanov
2015-08-30 8:42 ` [U-Boot] [PATCH 3/5] splash_source: add support for filesystem formatted usb Nikita Kiryanov
2015-10-21 13:01 ` Igor Grinberg
2015-10-23 10:23 ` Nikita Kiryanov
2015-10-23 13:12 ` Igor Grinberg [this message]
2015-10-26 12:00 ` Nikita Kiryanov
2015-08-30 8:42 ` [U-Boot] [PATCH 4/5] splash_source: add support for fileystem formatted sata Nikita Kiryanov
2015-08-30 8:42 ` [U-Boot] [PATCH 5/5] arm: mx6: cm-fx6: add splash locations to cm-fx6 Nikita Kiryanov
2015-10-21 12:30 ` Igor Grinberg
2015-08-30 9:42 ` [U-Boot] [PATCH 0/5] Add support for additional splash screen locations Nikita Kiryanov
2015-09-21 16:11 ` Nikita Kiryanov
2015-10-21 11:52 ` Nikita Kiryanov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=562A3221.5070804@compulab.co.il \
--to=grinberg@compulab.co.il \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox