From mboxrd@z Thu Jan 1 00:00:00 1970 From: Igor Grinberg Date: Fri, 23 Oct 2015 16:12:01 +0300 Subject: [U-Boot] [PATCH 3/5] splash_source: add support for filesystem formatted usb In-Reply-To: <20151023102338.GC11008@skynet> References: <1440924156-11309-1-git-send-email-nikita@compulab.co.il> <1440924156-11309-4-git-send-email-nikita@compulab.co.il> <56278CBA.5080104@compulab.co.il> <20151023102338.GC11008@skynet> Message-ID: <562A3221.5070804@compulab.co.il> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On 10/23/15 13:23, Nikita Kiryanov wrote: > On Wed, Oct 21, 2015 at 04:01:46PM +0300, Igor Grinberg wrote: >> On 08/30/15 11:42, Nikita Kiryanov wrote: >>> Add support for loading splash image from USB drive formatted with a >>> filesystem. >>> >>> Cc: Igor Grinberg >>> Cc: Tom Rini >>> Signed-off-by: Nikita Kiryanov >> >> [...] >> >>> +#ifdef CONFIG_USB_STORAGE >>> + if (location->storage == SPLASH_STORAGE_USB) { >>> + usb_init(); >>> + usb_stor_scan(1); >>> + } >>> +#endif >> >> Can we use IS_ENABLED() stuff here instead? > > IS_ENABLED() does not prevent compile errors, only closes off certain > code paths. Ok. Any other ways to not have that ifdefferry inside functions? -- Regards, Igor.