* [U-Boot] [PATCH] at91: simplify spl board_init_f function
@ 2015-10-23 9:23 Josh Wu
2015-10-23 15:40 ` Simon Glass
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Josh Wu @ 2015-10-23 9:23 UTC (permalink / raw)
To: u-boot
crt0.S do both memset the bss section and call board_init_r for us, so
remove them from board_init_f().
Signed-off-by: Josh Wu <josh.wu@atmel.com>
---
arch/arm/mach-at91/spl_atmel.c | 5 -----
1 file changed, 5 deletions(-)
diff --git a/arch/arm/mach-at91/spl_atmel.c b/arch/arm/mach-at91/spl_atmel.c
index 8ac5335..b2fb51d 100644
--- a/arch/arm/mach-at91/spl_atmel.c
+++ b/arch/arm/mach-at91/spl_atmel.c
@@ -98,9 +98,4 @@ void board_init_f(ulong dummy)
preloader_console_init();
mem_init();
-
- /* Clear the BSS. */
- memset(__bss_start, 0, __bss_end - __bss_start);
-
- board_init_r(NULL, 0);
}
--
1.9.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [U-Boot] [PATCH] at91: simplify spl board_init_f function
2015-10-23 9:23 [U-Boot] [PATCH] at91: simplify spl board_init_f function Josh Wu
@ 2015-10-23 15:40 ` Simon Glass
2015-10-23 22:46 ` Andreas Bießmann
2015-11-01 21:02 ` [U-Boot] " Andreas Bießmann
2 siblings, 0 replies; 4+ messages in thread
From: Simon Glass @ 2015-10-23 15:40 UTC (permalink / raw)
To: u-boot
On 23 October 2015 at 03:23, Josh Wu <josh.wu@atmel.com> wrote:
> crt0.S do both memset the bss section and call board_init_r for us, so
> remove them from board_init_f().
>
> Signed-off-by: Josh Wu <josh.wu@atmel.com>
> ---
>
> arch/arm/mach-at91/spl_atmel.c | 5 -----
> 1 file changed, 5 deletions(-)
Reviewed-by: Simon Glass <sjg@chromium.org>
^ permalink raw reply [flat|nested] 4+ messages in thread
* [U-Boot] [PATCH] at91: simplify spl board_init_f function
2015-10-23 9:23 [U-Boot] [PATCH] at91: simplify spl board_init_f function Josh Wu
2015-10-23 15:40 ` Simon Glass
@ 2015-10-23 22:46 ` Andreas Bießmann
2015-11-01 21:02 ` [U-Boot] " Andreas Bießmann
2 siblings, 0 replies; 4+ messages in thread
From: Andreas Bießmann @ 2015-10-23 22:46 UTC (permalink / raw)
To: u-boot
On 23.10.15 11:23, Josh Wu wrote:
> crt0.S do both memset the bss section and call board_init_r for us, so
> remove them from board_init_f().
>
> Signed-off-by: Josh Wu <josh.wu@atmel.com>
Reviewed-by: Andreas Bie?mann <andreas.devel@googlemail.com>
> ---
>
> arch/arm/mach-at91/spl_atmel.c | 5 -----
> 1 file changed, 5 deletions(-)
>
> diff --git a/arch/arm/mach-at91/spl_atmel.c b/arch/arm/mach-at91/spl_atmel.c
> index 8ac5335..b2fb51d 100644
> --- a/arch/arm/mach-at91/spl_atmel.c
> +++ b/arch/arm/mach-at91/spl_atmel.c
> @@ -98,9 +98,4 @@ void board_init_f(ulong dummy)
> preloader_console_init();
>
> mem_init();
> -
> - /* Clear the BSS. */
> - memset(__bss_start, 0, __bss_end - __bss_start);
> -
> - board_init_r(NULL, 0);
> }
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* [U-Boot] at91: simplify spl board_init_f function
2015-10-23 9:23 [U-Boot] [PATCH] at91: simplify spl board_init_f function Josh Wu
2015-10-23 15:40 ` Simon Glass
2015-10-23 22:46 ` Andreas Bießmann
@ 2015-11-01 21:02 ` Andreas Bießmann
2 siblings, 0 replies; 4+ messages in thread
From: Andreas Bießmann @ 2015-11-01 21:02 UTC (permalink / raw)
To: u-boot
Dear Josh Wu,
Josh Wu <josh.wu@atmel.com> writes:
>crt0.S do both memset the bss section and call board_init_r for us, so
>remove them from board_init_f().
>
>Signed-off-by: Josh Wu <josh.wu@atmel.com>
>Reviewed-by: Simon Glass <sjg@chromium.org>
>Reviewed-by: Andreas Bie?mann <andreas.devel@googlemail.com>
>---
>
> arch/arm/mach-at91/spl_atmel.c | 5 -----
> 1 file changed, 5 deletions(-)
applied to u-boot-atmel/master, thanks!
Best regards,
Andreas Bie?mann
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2015-11-01 21:02 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-10-23 9:23 [U-Boot] [PATCH] at91: simplify spl board_init_f function Josh Wu
2015-10-23 15:40 ` Simon Glass
2015-10-23 22:46 ` Andreas Bießmann
2015-11-01 21:02 ` [U-Boot] " Andreas Bießmann
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox