public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: "Andreas Bießmann" <andreas.devel@googlemail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 1/4] mmc: atmel: Silence debug output
Date: Sat, 24 Oct 2015 00:48:15 +0200	[thread overview]
Message-ID: <562AB92F.1080208@googlemail.com> (raw)
In-Reply-To: <1445625991-5343-1-git-send-email-marex@denx.de>



On 23.10.15 20:46, Marek Vasut wrote:
> This driver generates clearly debugging prints when changing clock
> speed, so silence those. Furthermore, the driver generates further
> prints in case a command fails to complete. The later case woud be
> useful, but for eMMC, command 8 can fail and it's not an error but
> a part of the specification. Thus, make this debug() as well.
> 
> Signed-off-by: Marek Vasut <marex@denx.de>

Reviewed-by: Andreas Bie?mann <andreas.devel@googlemail.com>

> ---
>  drivers/mmc/gen_atmel_mci.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/mmc/gen_atmel_mci.c b/drivers/mmc/gen_atmel_mci.c
> index 45bcffb..2815e57 100644
> --- a/drivers/mmc/gen_atmel_mci.c
> +++ b/drivers/mmc/gen_atmel_mci.c
> @@ -48,8 +48,8 @@ static unsigned int atmel_mci_get_version(struct atmel_mci *mci)
>   */
>  static void dump_cmd(u32 cmdr, u32 arg, u32 status, const char* msg)
>  {
> -	printf("gen_atmel_mci: CMDR %08x (%2u) ARGR %08x (SR: %08x) %s\n",
> -		cmdr, cmdr&0x3F, arg, status, msg);
> +	debug("gen_atmel_mci: CMDR %08x (%2u) ARGR %08x (SR: %08x) %s\n",
> +	      cmdr, cmdr & 0x3F, arg, status, msg);
>  }
>  
>  /* Setup for MCI Clock and Block Size */
> @@ -73,7 +73,7 @@ static void mci_set_mode(struct mmc *mmc, u32 hz, u32 blklen)
>  			clkodd = clkdiv & 1;
>  			clkdiv >>= 1;
>  
> -			printf("mci: setting clock %u Hz, block size %u\n",
> +			debug("mci: setting clock %u Hz, block size %u\n",
>  			       bus_hz / (clkdiv * 2 + clkodd + 2), blklen);
>  		} else {
>  			/* find clkdiv yielding a rate <= than requested */
> @@ -81,7 +81,7 @@ static void mci_set_mode(struct mmc *mmc, u32 hz, u32 blklen)
>  				if ((bus_hz / (clkdiv + 1) / 2) <= hz)
>  					break;
>  			}
> -			printf("mci: setting clock %u Hz, block size %u\n",
> +			debug("mci: setting clock %u Hz, block size %u\n",
>  			       (bus_hz / (clkdiv + 1)) / 2, blklen);
>  
>  		}
> 

  parent reply	other threads:[~2015-10-23 22:48 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-10-23 18:46 [U-Boot] [PATCH 1/4] mmc: atmel: Silence debug output Marek Vasut
2015-10-23 18:46 ` [U-Boot] [PATCH 2/4] mmc: atmel: Fix clock configuration Marek Vasut
2015-10-23 22:49   ` Andreas Bießmann
2015-11-01 21:02   ` [U-Boot] [U-Boot,2/4] " Andreas Bießmann
2015-10-23 18:46 ` [U-Boot] [PATCH 3/4] mmc: atmel: Implement proper private data Marek Vasut
2015-10-23 22:59   ` Andreas Bießmann
2015-10-23 23:29     ` Marek Vasut
2015-10-24  8:35       ` Andreas Bießmann
2015-10-24 12:52         ` Marek Vasut
2015-11-01 21:03   ` [U-Boot] [U-Boot, " Andreas Bießmann
2015-10-23 18:46 ` [U-Boot] [PATCH 4/4] mmc: atmel: Zap global 'initialized' variable Marek Vasut
2015-10-23 23:00   ` Andreas Bießmann
2015-11-01 21:03   ` [U-Boot] [U-Boot, " Andreas Bießmann
2015-10-23 22:48 ` Andreas Bießmann [this message]
2015-11-01 21:02 ` [U-Boot] [U-Boot,1/4] mmc: atmel: Silence debug output Andreas Bießmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=562AB92F.1080208@googlemail.com \
    --to=andreas.devel@googlemail.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox