public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Thomas Chou <thomas@wytron.com.tw>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] nios2: add memory to board info
Date: Tue, 27 Oct 2015 08:43:11 +0800	[thread overview]
Message-ID: <562EC89F.7080806@wytron.com.tw> (raw)
In-Reply-To: <201510262124.00891.marex@denx.de>

Hi Marek,

On 10/27/2015 04:24 AM, Marek Vasut wrote:
> On Monday, October 26, 2015 at 10:19:32 AM, Thomas Chou wrote:
>> Run setup_board_part1/2 and add memory information to board info
>> structure. So that it can display correct values in bdinfo command.
>>
>> Signed-off-by: Thomas Chou <thomas@wytron.com.tw>
>> ---
>>   common/board_f.c | 4 ++--
>>   1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/common/board_f.c b/common/board_f.c
>> index d88ada3..6ab74d9 100644
>> --- a/common/board_f.c
>> +++ b/common/board_f.c
>> @@ -551,7 +551,7 @@ static int display_new_sp(void)
>>   	return 0;
>>   }
>>
>> -#if defined(CONFIG_PPC) || defined(CONFIG_M68K)
>> +#if defined(CONFIG_PPC) || defined(CONFIG_M68K) || defined(CONFIG_NIOS2)
>
> This looks like some ancient code, due to the fact that it's used on
> PPC and M68K only, but not on ARM for example.
>

Thanks for the review. I will try to follow ARM's.

Best regards,
Thomas

  reply	other threads:[~2015-10-27  0:43 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-10-26  9:19 [U-Boot] [PATCH] nios2: add memory to board info Thomas Chou
2015-10-26 20:24 ` Marek Vasut
2015-10-27  0:43   ` Thomas Chou [this message]
2015-10-27  2:23 ` [U-Boot] [PATCH v2] nios2: use dram bank in " Thomas Chou
2015-10-27  9:19   ` Marek Vasut
2015-11-03  5:15   ` Thomas Chou

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=562EC89F.7080806@wytron.com.tw \
    --to=thomas@wytron.com.tw \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox