From: Stefan Roese <sr@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] cfi_flash: use specific width types for cword
Date: Tue, 27 Oct 2015 12:20:14 +0100 [thread overview]
Message-ID: <562F5DEE.4000607@denx.de> (raw)
In-Reply-To: <1445615451-4471-1-git-send-email-ryan.harkin@linaro.org>
On 23.10.2015 17:50, Ryan Harkin wrote:
> This patch changes the cword union to use specific length types that are
> architecture indepented.
>
> This patch also renames the members of the cword union to represent
> their usage, i.e.:
>
> c -> w8
> s -> w16
> l -> w32
> ll -> w64
>
> Where "w" stands for "width" in bits.
>
> I discovered this problem when enabling CFI flash on vexpress64.
> cword.l was an unsigned long int, but it was intended to be 32 bits wide.
> Unfortunately, it's 64-bits wide on a 64-bit system, meaning that a
> 64-bit system fails when attempting to use 32-bit wide CFI flash parts.
>
> Similar problems also existed with the other cword sizes.
>
> Signed-off-by: Ryan Harkin <ryan.harkin@linaro.org>
Applied to u-boot-cfi-flash/master.
Thanks,
Stefan
prev parent reply other threads:[~2015-10-27 11:20 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-23 15:50 [U-Boot] [PATCH] cfi_flash: use specific width types for cword Ryan Harkin
2015-10-27 10:31 ` Linus Walleij
2015-10-27 11:20 ` Stefan Roese [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=562F5DEE.4000607@denx.de \
--to=sr@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox