From: Stefan Roese <sr@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v0 4/5] arm: mvebu: Fix ddr3_init() cpu config
Date: Wed, 28 Oct 2015 17:35:56 +0100 [thread overview]
Message-ID: <5630F96C.1050507@denx.de> (raw)
In-Reply-To: <1446047056-16801-5-git-send-email-dirk.eibach@gdsys.cc>
Hi Dirk,
On 28.10.2015 16:44, dirk.eibach at gdsys.cc wrote:
> From: Dirk Eibach <dirk.eibach@gdsys.cc>
>
> Armada 38x has a maximum of two cores. Probably copy/paste
> bug from Armada XP.
>
> Signed-off-by: Dirk Eibach <dirk.eibach@gdsys.cc>
> ---
>
> drivers/ddr/marvell/a38x/ddr3_init.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/ddr/marvell/a38x/ddr3_init.c b/drivers/ddr/marvell/a38x/ddr3_init.c
> index d6ed8e0..cbfc58c 100644
> --- a/drivers/ddr/marvell/a38x/ddr3_init.c
> +++ b/drivers/ddr/marvell/a38x/ddr3_init.c
> @@ -306,8 +306,6 @@ int ddr3_init(void)
> SAR1_CPU_CORE_OFFSET;
> switch (soc_num) {
> case 0x3:
> - reg_bit_set(CPU_CONFIGURATION_REG(3), CPU_MRVL_ID_OFFSET);
> - reg_bit_set(CPU_CONFIGURATION_REG(2), CPU_MRVL_ID_OFFSET);
> case 0x1:
> reg_bit_set(CPU_CONFIGURATION_REG(1), CPU_MRVL_ID_OFFSET);
> case 0x0:
Shouldn't you remove the "case 0x3:" line as well?
Thanks,
Stefan
next prev parent reply other threads:[~2015-10-28 16:35 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-28 15:44 [U-Boot] [PATCH v0 0/5] Some improvements for mvebu/a38x dirk.eibach at gdsys.cc
2015-10-28 15:44 ` [U-Boot] [PATCH v0 1/5] pci: mvebu: Fix Armada 38x support dirk.eibach at gdsys.cc
2015-10-28 16:24 ` Stefan Roese
2015-11-17 12:55 ` Anton Schubert
2015-11-18 12:48 ` Dirk Eibach
2015-11-18 13:23 ` Anton Schubert
2015-11-18 14:51 ` Dirk Eibach
2015-10-28 15:44 ` [U-Boot] [PATCH v0 2/5] arm: mvebu: Add gpio support dirk.eibach at gdsys.cc
2015-10-28 16:41 ` Stefan Roese
2015-10-28 15:44 ` [U-Boot] [PATCH v0 3/5] arm: mvebu: Fix SAR1_CPU_CORE_MASK dirk.eibach at gdsys.cc
2015-10-28 16:34 ` Stefan Roese
2015-10-29 9:41 ` Dirk Eibach
2015-10-29 9:45 ` Luka Perkov
2015-10-28 15:44 ` [U-Boot] [PATCH v0 4/5] arm: mvebu: Fix ddr3_init() cpu config dirk.eibach at gdsys.cc
2015-10-28 16:35 ` Stefan Roese [this message]
2015-10-29 9:51 ` Dirk Eibach
2015-10-29 10:03 ` Stefan Roese
2016-03-24 8:37 ` Stefan Roese
2015-10-28 15:44 ` [U-Boot] [PATCH v0 5/5] spi: Add support for Armada 38x second controller dirk.eibach at gdsys.cc
2015-10-28 16:29 ` Jagan Teki
2015-10-28 16:39 ` Stefan Roese
2015-10-29 9:54 ` Dirk Eibach
2015-10-29 10:02 ` Stefan Roese
2015-10-29 10:31 ` Dirk Eibach
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5630F96C.1050507@denx.de \
--to=sr@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox