From: Thomas Chou <thomas@wytron.com.tw>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] nios2: add 10m50 devboard support
Date: Thu, 29 Oct 2015 13:34:55 +0800 [thread overview]
Message-ID: <5631AFFF.70202@wytron.com.tw> (raw)
In-Reply-To: <201510290045.42299.marex@denx.de>
Hi Marek,
On 10/29/2015 07:45 AM, Marek Vasut wrote:
>> +# CONFIG_CMD_SETEXPR is not set
>
> Please keep setexpr, it's really useful.
OK, I will keep it.
>> +/*
>> + * MII/PHY
>> + */
>> +#define CONFIG_CMD_MII 1
>> +#define CONFIG_PHY_GIGE 1
>> +#define CONFIG_SYS_FAULT_ECHO_LINK_DOWN 1
>> +#define CONFIG_PHY_MARVELL 1
>
> Are you sure all these macros must have a value (1) ? I doubt it.
Oops, these '1' should be removed.
I will resend this patch after I finish the altera quadspi and altera
tse msgdma update. Thank you.
Best regards,
Thomas
next prev parent reply other threads:[~2015-10-29 5:34 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-26 0:15 [U-Boot] [PATCH] nios2: add 10m50 devboard support Thomas Chou
2015-10-28 23:45 ` Marek Vasut
2015-10-29 5:34 ` Thomas Chou [this message]
2015-10-29 13:16 ` Marek Vasut
2015-11-09 6:52 ` [U-Boot] [PATCH v2] mtd: add altera quadspi driver Thomas Chou
2015-11-09 6:59 ` Thomas Chou
2015-11-09 6:59 ` [U-Boot] [PATCH v2] nios2: add 10m50 devboard support Thomas Chou
2015-11-09 14:27 ` Marek Vasut
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5631AFFF.70202@wytron.com.tw \
--to=thomas@wytron.com.tw \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox