From: Heiko Schocher <hs@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 3/8] cmd_sf: Use mtd->size instead of flash->size
Date: Thu, 29 Oct 2015 07:32:12 +0100 [thread overview]
Message-ID: <5631BD6C.6030104@denx.de> (raw)
In-Reply-To: <1444679655-30349-3-git-send-email-jteki@openedev.com>
Hello Jagan,
Am 12.10.2015 um 21:54 schrieb Jagan Teki:
> Since mtd got added, replace flash->size with mtd->size.
>
> Signed-off-by: Jagan Teki <jteki@openedev.com>
> ---
> common/cmd_sf.c | 16 ++++++++--------
> 1 file changed, 8 insertions(+), 8 deletions(-)
Reviewed-by: Heiko Schocher <hs@denx.de>
bye,
Heiko
>
> diff --git a/common/cmd_sf.c b/common/cmd_sf.c
> index ac7f5df..a501376 100644
> --- a/common/cmd_sf.c
> +++ b/common/cmd_sf.c
> @@ -275,13 +275,13 @@ static int do_spi_flash_read_write(int argc, char * const argv[])
> return -1;
>
> if (mtd_arg_off_size(argc - 2, &argv[2], &dev, &offset, &len,
> - &maxsize, MTD_DEV_TYPE_NOR, flash->size))
> + &maxsize, MTD_DEV_TYPE_NOR, flash->mtd->size))
> return -1;
>
> /* Consistency checking */
> - if (offset + len > flash->size) {
> - printf("ERROR: attempting %s past flash size (%#x)\n",
> - argv[0], flash->size);
> + if (offset + len > flash->mtd->size) {
> + printf("ERROR: attempting %s past flash size (0x%llx)\n",
> + argv[0], flash->mtd->size);
> return 1;
> }
>
> @@ -327,7 +327,7 @@ static int do_spi_flash_erase(int argc, char * const argv[])
> return -1;
>
> if (mtd_arg_off(argv[1], &dev, &offset, &len, &maxsize,
> - MTD_DEV_TYPE_NOR, flash->size))
> + MTD_DEV_TYPE_NOR, flash->mtd->size))
> return -1;
>
> ret = sf_parse_len_arg(argv[2], &size);
> @@ -335,9 +335,9 @@ static int do_spi_flash_erase(int argc, char * const argv[])
> return -1;
>
> /* Consistency checking */
> - if (offset + size > flash->size) {
> - printf("ERROR: attempting %s past flash size (%#x)\n",
> - argv[0], flash->size);
> + if (offset + size > flash->mtd->size) {
> + printf("ERROR: attempting %s past flash size (0x%llx)\n",
> + argv[0], flash->mtd->size);
> return 1;
> }
>
>
--
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
next prev parent reply other threads:[~2015-10-29 6:32 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-12 19:54 [U-Boot] [PATCH 1/8] sf: Add MTD support to spi_flash Jagan Teki
2015-10-12 19:54 ` [U-Boot] [PATCH 2/8] sf: Use mtd_info ops instead of spi_flash ops Jagan Teki
2015-10-29 6:29 ` Heiko Schocher
2015-10-12 19:54 ` [U-Boot] [PATCH 3/8] cmd_sf: Use mtd->size instead of flash->size Jagan Teki
2015-10-29 6:32 ` Heiko Schocher [this message]
2015-10-12 19:54 ` [U-Boot] [PATCH 4/8] dm-sf: use mtd_ops, drop dm_spi_flash_ops Jagan Teki
2015-10-29 6:35 ` Heiko Schocher
2015-10-29 13:11 ` Jagan Teki
2015-11-06 3:15 ` Simon Glass
2015-10-12 19:54 ` [U-Boot] [PATCH 5/8] sf: Add MTD support for non-dm spi_flash interface Jagan Teki
2015-10-29 6:37 ` Heiko Schocher
2015-10-12 19:54 ` [U-Boot] [PATCH 6/8] sf: probe: Minor cleanup Jagan Teki
2015-10-29 6:54 ` Heiko Schocher
2015-10-12 19:54 ` [U-Boot] [PATCH 7/8] sf: Drop SPI_FLASH_MTD driver Jagan Teki
2015-10-12 19:54 ` [U-Boot] [PATCH 8/8] configs: Remove CONFIG_SPI_FLASH_MTD Jagan Teki
2015-10-29 6:04 ` [U-Boot] [PATCH 1/8] sf: Add MTD support to spi_flash Heiko Schocher
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5631BD6C.6030104@denx.de \
--to=hs@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox