From mboxrd@z Thu Jan  1 00:00:00 1970
From: Jaehoon Chung <jh80.chung@samsung.com>
Date: Thu, 29 Oct 2015 16:29:22 +0900
Subject: [U-Boot] [PATCH 1/2] Exynos4412: pinmux: disable pull for MMC
	pins
In-Reply-To: <1446043310-21519-1-git-send-email-p.marczak@samsung.com>
References: <1446043310-21519-1-git-send-email-p.marczak@samsung.com>
Message-ID: <5631CAD2.6090400@samsung.com>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Hi,

Looks good to me.

Acked-by: Jaehoon Chung <jh80.chung@samsung.com>

Best Regards,
Jaehoon Chung

On 10/28/2015 11:41 PM, Przemyslaw Marczak wrote:
> There are 8 pins for SD card in Exynos, but the MUX was configured
> only for 7, since the one was used for card detection.
> This caused the pin's pull wrong configuration.
> 
> This commit fixes this and the card detect can work properly,
> after call this function.
> 
> Tested-on: Odroid U3 and Odroid X2.
> 
> Signed-off-by: Przemyslaw Marczak <p.marczak@samsung.com>
> Cc: Guillaume GARDET <guillaume.gardet@free.fr>
> Cc: Lukasz Majewski <l.majewski@samsung.com>
> Cc: Jaehoon Chung <jh80.chung@samsung.com>
> Cc: Minkyu Kang <mk7.kang@samsung.com>
> Cc: Simon Glass <sjg@chromium.org>
> ---
>  arch/arm/mach-exynos/pinmux.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/arm/mach-exynos/pinmux.c b/arch/arm/mach-exynos/pinmux.c
> index 179b294..925bd0a 100644
> --- a/arch/arm/mach-exynos/pinmux.c
> +++ b/arch/arm/mach-exynos/pinmux.c
> @@ -737,10 +737,10 @@ static int exynos4x12_mmc_config(int peripheral, int flags)
>  		return -1;
>  	}
>  	for (i = start; i < (start + 7); i++) {
> +		gpio_set_pull(i, S5P_GPIO_PULL_NONE);
>  		if (i == (start + 2))
>  			continue;
>  		gpio_cfg_pin(i,  func);
> -		gpio_set_pull(i, S5P_GPIO_PULL_NONE);
>  		gpio_set_drv(i, S5P_GPIO_DRV_4X);
>  	}
>  	if (flags & PINMUX_FLAG_8BIT_MODE) {
>