* [U-Boot] [PATCH] mmc: sdhci: assigned to current clock value for host->clock
@ 2015-10-29 7:53 Jaehoon Chung
2015-10-29 8:40 ` Minkyu Kang
0 siblings, 1 reply; 2+ messages in thread
From: Jaehoon Chung @ 2015-10-29 7:53 UTC (permalink / raw)
To: u-boot
There is no place where host->clock is assgined to any value.
If real clock is changed to mmc->clock, host->clock can be assigned to
mmc->clock. If card request to same clock value, it doesn't need to
call sdhci_set_clock() function.
Signed-off-by: Jaehoon Chung <jh80.chung@samsung.com>
---
drivers/mmc/sdhci.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/mmc/sdhci.c b/drivers/mmc/sdhci.c
index d89e302..3f87a23 100644
--- a/drivers/mmc/sdhci.c
+++ b/drivers/mmc/sdhci.c
@@ -380,8 +380,10 @@ static void sdhci_set_ios(struct mmc *mmc)
if (host->set_control_reg)
host->set_control_reg(host);
- if (mmc->clock != host->clock)
- sdhci_set_clock(mmc, mmc->clock);
+ if (mmc->clock != host->clock) {
+ if (!sdhci_set_clock(mmc, mmc->clock))
+ host->clock = mmc->clock;
+ }
/* Set bus width */
ctrl = sdhci_readb(host, SDHCI_HOST_CONTROL);
--
1.9.1
^ permalink raw reply related [flat|nested] 2+ messages in thread* [U-Boot] [PATCH] mmc: sdhci: assigned to current clock value for host->clock
2015-10-29 7:53 [U-Boot] [PATCH] mmc: sdhci: assigned to current clock value for host->clock Jaehoon Chung
@ 2015-10-29 8:40 ` Minkyu Kang
0 siblings, 0 replies; 2+ messages in thread
From: Minkyu Kang @ 2015-10-29 8:40 UTC (permalink / raw)
To: u-boot
Hi!
On 29/10/15 16:53, Jaehoon Chung wrote:
> There is no place where host->clock is assgined to any value.
> If real clock is changed to mmc->clock, host->clock can be assigned to
> mmc->clock. If card request to same clock value, it doesn't need to
> call sdhci_set_clock() function.
>
> Signed-off-by: Jaehoon Chung <jh80.chung@samsung.com>
> ---
> drivers/mmc/sdhci.c | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/mmc/sdhci.c b/drivers/mmc/sdhci.c
> index d89e302..3f87a23 100644
> --- a/drivers/mmc/sdhci.c
> +++ b/drivers/mmc/sdhci.c
> @@ -380,8 +380,10 @@ static void sdhci_set_ios(struct mmc *mmc)
> if (host->set_control_reg)
> host->set_control_reg(host);
>
> - if (mmc->clock != host->clock)
> - sdhci_set_clock(mmc, mmc->clock);
> + if (mmc->clock != host->clock) {
> + if (!sdhci_set_clock(mmc, mmc->clock))
> + host->clock = mmc->clock;
I think it's better to move into sdhci_set_clock function.
> + }
>
> /* Set bus width */
> ctrl = sdhci_readb(host, SDHCI_HOST_CONTROL);
>
Thanks,
Minkyu Kang.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-10-29 8:40 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-10-29 7:53 [U-Boot] [PATCH] mmc: sdhci: assigned to current clock value for host->clock Jaehoon Chung
2015-10-29 8:40 ` Minkyu Kang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox