[U-Boot] [PATCH v4 4/6] cgtqmx6eval: Add SPL support

[Stefano Babic <sbabic@denx.de>]

On 29/10/2015 12:15, Otavio Salvador wrote:
> On Thu, Oct 29, 2015 at 9:07 AM, Stefano Babic <sbabic@denx.de> wrote:
>> On 29/10/2015 11:58, Otavio Salvador wrote:
>>> On Thu, Oct 29, 2015 at 8:53 AM, Stefano Babic <sbabic@denx.de> wrote:
>>>> Hi Otavio,
>>>>
>>>> On 29/10/2015 11:32, Otavio Salvador wrote:
>>>>> Congatec has several MX6 boards based on quad, dual, dual-lite and solo.
>>>>>
>>>>> Add SPL support so that all the variants can be supported.
>>>>>
>>>>> Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
>>> ...
>>>>> --- a/board/congatec/cgtqmx6eval/README
>>>>> +++ b/board/congatec/cgtqmx6eval/README
>>> ...
>>>>> +=> sf update 0x12000000 0x400 0x10000
>>>>> +
>>>>> +=> tftp u-boot.img
>>>>
>>>> Just a nitpick. This assumes that loadaddr is set to 0x12000000, as it
>>>> is in mx6_common.h. If value changes, it is not strictly correct. Maybe
>>>> to avoid confusion, you can write "tftp 0x12000000 SPL" (explicitely
>>>> address it) or you change sf update to use the loadaddr variable as "sf
>>>> update ${loadaddr} 0x400 0x10000"
>>>
>>> Can you replace it with ${loadaddr} when applying or do you want a new
>>> patch revision?
>>
>> Yes, of course - I'll do it, you do not need to repost it for this.
> 
> Bear in mind, this required Fabio's patches for SPI protection.


Ok - thanks !

Regards,
Stefao


-- 
=====================================================================
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================