From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Chou Date: Fri, 30 Oct 2015 07:27:58 +0800 Subject: [U-Boot] [PATCH] sandbox: add a sandbox timer and basic test In-Reply-To: References: <1445520317-24516-1-git-send-email-thomas@wytron.com.tw> Message-ID: <5632AB7E.9030600@wytron.com.tw> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hi Simon, On 10/30/2015 01:16 AM, Simon Glass wrote: > Hi Thomas, > > On 22 October 2015 at 07:25, Thomas Chou wrote: >> Add a sandbox timer which get time from host os and a basic >> test. >> >> Signed-off-by: Thomas Chou >> --- >> arch/sandbox/dts/sandbox.dts | 4 ++ >> board/sandbox/sandbox.c | 2 + >> common/board_f.c | 2 +- >> configs/sandbox_defconfig | 2 + >> doc/device-tree-bindings/timer/sandbox_timer.txt | 7 ++++ >> drivers/timer/Kconfig | 7 ++++ >> drivers/timer/Makefile | 1 + >> drivers/timer/sandbox_timer.c | 53 ++++++++++++++++++++++++ >> include/configs/sandbox.h | 2 + >> test/dm/Makefile | 1 + >> test/dm/timer.c | 27 ++++++++++++ > > Can you please split out the board_f.c change into a separate commit? But the sandbox will fail (with seg fault or hang) without the change in board_f.c . Is this alright? >> +static const struct udevice_id sandbox_timer_ids[] = { >> + { .compatible = "sandbox,timer", }, > > You can drop the penultimate comma. > OK. Thanks a lot for your review. Best regards, Thomas