From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mugunthan V N Date: Sat, 31 Oct 2015 17:16:14 +0530 Subject: [U-Boot] [PATCH 07/13] drivers: spi: ti_qspi: convert driver to adopt device driver model In-Reply-To: References: <1445944388-14207-1-git-send-email-mugunthanvnm@ti.com> <1445944388-14207-8-git-send-email-mugunthanvnm@ti.com> Message-ID: <5634AA06.1050101@ti.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Thursday 29 October 2015 10:48 PM, Simon Glass wrote: >> + if (flash_num == 0) { >> > + debug("Error: Missing flashes!\n"); >> > + return -ENODEV; >> > + } > It looks like flash_num is only used for the debug message. Why not > just drop this? The driver should not be scanning the device tree - it > should be able to look at the number of child devices instead. > Hmmm, will fix in v2 Regards Mugunthan V N