public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Angelo Dureghello <angelo@sysam.it>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH V2] common: Simplify get_clocks() #ifdef
Date: Sun, 01 Nov 2015 16:07:09 +0100	[thread overview]
Message-ID: <56362A9D.8010107@sysam.it> (raw)
In-Reply-To: <1446197402-1564-1-git-send-email-Peng.Fan@freescale.com>

Hi Peng,

On 30/10/2015 10:30, Peng Fan wrote:
> get_clocks is wrapped by CONFIG_FSL_CLK and CONFIG_M68K in seperate
> piece code. They can be merged into one snippet.
>
> Signed-off-by: Peng Fan <Peng.Fan@freescale.com>
> Cc: Tom Rini <trini@konsulko.com>
> Cc: Simon Glass <sjg@chromium.org>
> Cc: Bin Meng <bmeng.cn@gmail.com>
> Cc: Alexey Brodkin <abrodkin@synopsys.com>
> Cc: "angelo at sysam.it" <angelo@sysam.it>
> Cc: Daniel Schwierzeck <daniel.schwierzeck@gmail.com>
> Cc: Stephen Warren <swarren@nvidia.com>
> Cc: "Andreas Bie?mann" <andreas.devel@googlemail.com>
> Reviewed-by: Simon Glass <sjg@chromium.org>
> ---
>
> Changes V2:
>   Refine patch subject as Simon suggested.
>   Add Simon's Reviewed-by
>
>   common/board_f.c | 5 +----
>   1 file changed, 1 insertion(+), 4 deletions(-)
>
> diff --git a/common/board_f.c b/common/board_f.c
> index 486e828..7bc05b1 100644
> --- a/common/board_f.c
> +++ b/common/board_f.c
> @@ -806,10 +806,7 @@ static init_fnc_t init_sequence_f[] = {
>   #if defined(CONFIG_BOARD_POSTCLK_INIT)
>   	board_postclk_init,
>   #endif
> -#ifdef CONFIG_FSL_CLK
> -	get_clocks,
> -#endif
> -#ifdef CONFIG_M68K
> +#if defined(CONFIG_FSL_CLK) || defined(CONFIG_M68K)
>   	get_clocks,
>   #endif
>   	env_init,		/* initialize environment */
>


change is ok for me.

Acked-by: Angelo Dureghello <angelo@sysam.it>

  reply	other threads:[~2015-11-01 15:07 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-10-30  9:30 [U-Boot] [PATCH V2] common: Simplify get_clocks() #ifdef Peng Fan
2015-11-01 15:07 ` Angelo Dureghello [this message]
2015-11-13  1:30 ` [U-Boot] [U-Boot,V2] " Tom Rini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=56362A9D.8010107@sysam.it \
    --to=angelo@sysam.it \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox