[U-Boot] [PATCH 4/8] serial: altera_uart: minor clean up

Jagan Teki
2015-10-30T08:12:23Z

On 30 October 2015 at 12:48, Thomas Chou <thomas@wytron.com.tw> wrote:
> - Moved macro definitions to top
> - Re-arrange header includes ascending order
> - Remove unused header linux/compiler.h
> - Remove the penultimate comma in of_match ids
>
> Signed-off-by: Thomas Chou <thomas@wytron.com.tw>
> ---

Reviewed-by: Jagan Teki <jteki@openedev.com>

> drivers/serial/altera_uart.c | 19 +++++++++----------
> 1 file changed, 9 insertions(+), 10 deletions(-)
>
> diff --git a/drivers/serial/altera_uart.c b/drivers/serial/altera_uart.c
> index 7d5197a..cc68b1c 100644
> --- a/drivers/serial/altera_uart.c
> +++ b/drivers/serial/altera_uart.c
> @@ -8,9 +8,15 @@
> #include <common.h>
> #include <dm.h>
> #include <errno.h>
> -#include <asm/io.h>
> -#include <linux/compiler.h>
> #include <serial.h>
> +#include <asm/io.h>
> +
> +DECLARE_GLOBAL_DATA_PTR;
> +
> +/* status register */
> +#define ALTERA_UART_TMT BIT(5) /* tx empty */
> +#define ALTERA_UART_TRDY BIT(6) /* tx ready */
> +#define ALTERA_UART_RRDY BIT(7) /* rx ready */
>
> struct altera_uart_regs {
> u32 rxdata; /* Rx data reg */
> @@ -26,13 +32,6 @@ struct altera_uart_platdata {
> unsigned int uartclk;
> };
>
> -/* status register */
> -#define ALTERA_UART_TMT BIT(5) /* tx empty */
> -#define ALTERA_UART_TRDY BIT(6) /* tx ready */
> -#define ALTERA_UART_RRDY BIT(7) /* rx ready */
> -
> -DECLARE_GLOBAL_DATA_PTR;
> -
> static int altera_uart_setbrg(struct udevice *dev, int baudrate)
> {
> struct altera_uart_platdata *plat = dev->platdata;
> @@ -106,7 +105,7 @@ static const struct dm_serial_ops altera_uart_ops = {
> };
>
> static const struct udevice_id altera_uart_ids[] = {
> - { .compatible = "altr,uart-1.0", },
> + { .compatible = "altr,uart-1.0" },
> { }
> };
>
> --
> 2.5.0

thanks!
--
Jagan | openedev.