public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Thomas Chou <thomas@wytron.com.tw>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 4/8] serial: altera_uart: minor clean up
Date: Tue, 3 Nov 2015 13:21:01 +0800	[thread overview]
Message-ID: <5638443D.2080807@wytron.com.tw> (raw)
In-Reply-To: <1446189498-26549-4-git-send-email-thomas@wytron.com.tw>



On 2015?10?30? 15:18, Thomas Chou wrote:
> - Moved macro definitions to top
> - Re-arrange header includes ascending order
> - Remove unused header linux/compiler.h
> - Remove the penultimate comma in of_match ids
>
> Signed-off-by: Thomas Chou <thomas@wytron.com.tw>
> ---
>   drivers/serial/altera_uart.c | 19 +++++++++----------
>   1 file changed, 9 insertions(+), 10 deletions(-)
>

Applied to u-boot-nios.


> diff --git a/drivers/serial/altera_uart.c b/drivers/serial/altera_uart.c
> index 7d5197a..cc68b1c 100644
> --- a/drivers/serial/altera_uart.c
> +++ b/drivers/serial/altera_uart.c
> @@ -8,9 +8,15 @@
>   #include <common.h>
>   #include <dm.h>
>   #include <errno.h>
> -#include <asm/io.h>
> -#include <linux/compiler.h>
>   #include <serial.h>
> +#include <asm/io.h>
> +
> +DECLARE_GLOBAL_DATA_PTR;
> +
> +/* status register */
> +#define ALTERA_UART_TMT		BIT(5)	/* tx empty */
> +#define ALTERA_UART_TRDY	BIT(6)	/* tx ready */
> +#define ALTERA_UART_RRDY	BIT(7)	/* rx ready */
>
>   struct altera_uart_regs {
>   	u32	rxdata;		/* Rx data reg */
> @@ -26,13 +32,6 @@ struct altera_uart_platdata {
>   	unsigned int uartclk;
>   };
>
> -/* status register */
> -#define ALTERA_UART_TMT		BIT(5)	/* tx empty */
> -#define ALTERA_UART_TRDY	BIT(6)	/* tx ready */
> -#define ALTERA_UART_RRDY	BIT(7)	/* rx ready */
> -
> -DECLARE_GLOBAL_DATA_PTR;
> -
>   static int altera_uart_setbrg(struct udevice *dev, int baudrate)
>   {
>   	struct altera_uart_platdata *plat = dev->platdata;
> @@ -106,7 +105,7 @@ static const struct dm_serial_ops altera_uart_ops = {
>   };
>
>   static const struct udevice_id altera_uart_ids[] = {
> -	{ .compatible = "altr,uart-1.0", },
> +	{ .compatible = "altr,uart-1.0" },
>   	{ }
>   };
>
>

  parent reply	other threads:[~2015-11-03  5:21 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-10-30  7:18 [U-Boot] [PATCH 1/8] serial: altera_jtag_uart: use BIT macro Thomas Chou
2015-10-30  7:18 ` [U-Boot] [PATCH 2/8] serial: altera_jtag_uart: minor clean up Thomas Chou
2015-10-30  8:09   ` Jagan Teki
2015-11-03  5:20   ` Thomas Chou
2015-10-30  7:18 ` [U-Boot] [PATCH 3/8] serial: altera_uart: use BIT macro Thomas Chou
2015-10-30  8:10   ` Jagan Teki
2015-11-03  5:20   ` Thomas Chou
2015-10-30  7:18 ` [U-Boot] [PATCH 4/8] serial: altera_uart: minor clean up Thomas Chou
2015-10-30  8:12   ` Jagan Teki
2015-11-03  5:21   ` Thomas Chou [this message]
2015-10-30  7:18 ` [U-Boot] [PATCH 5/8] timer: altera_timer: use BIT macro Thomas Chou
2015-10-30  8:13   ` Jagan Teki
2015-11-03  5:21   ` Thomas Chou
2015-10-30  7:18 ` [U-Boot] [PATCH 6/8] timer: altera_timer: minor clean up Thomas Chou
2015-10-30  8:13   ` Jagan Teki
2015-11-03  5:21   ` Thomas Chou
2015-10-30  7:18 ` [U-Boot] [PATCH 7/8] misc: altera_sysid: " Thomas Chou
2015-10-30  8:14   ` Jagan Teki
2015-11-03  5:21   ` Thomas Chou
2015-10-30  7:18 ` [U-Boot] [PATCH 8/8] spi: altera_spi: " Thomas Chou
2015-10-30  8:15   ` Jagan Teki
2015-11-03  5:22   ` Thomas Chou
2015-10-30  8:07 ` [U-Boot] [PATCH 1/8] serial: altera_jtag_uart: use BIT macro Jagan Teki
2015-11-03  5:19 ` Thomas Chou

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5638443D.2080807@wytron.com.tw \
    --to=thomas@wytron.com.tw \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox