From: Thomas Chou <thomas@wytron.com.tw>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 6/8] timer: altera_timer: minor clean up
Date: Tue, 3 Nov 2015 13:21:33 +0800 [thread overview]
Message-ID: <5638445D.8060908@wytron.com.tw> (raw)
In-Reply-To: <1446189498-26549-6-git-send-email-thomas@wytron.com.tw>
On 2015?10?30? 15:18, Thomas Chou wrote:
> - Moved macro definitions to top
> - Remove the penultimate comma in of_match ids
>
> Signed-off-by: Thomas Chou <thomas@wytron.com.tw>
> ---
> drivers/timer/altera_timer.c | 12 ++++++------
> 1 file changed, 6 insertions(+), 6 deletions(-)
>
Applied to u-boot-nios.
> diff --git a/drivers/timer/altera_timer.c b/drivers/timer/altera_timer.c
> index 288357c..7952ad7 100644
> --- a/drivers/timer/altera_timer.c
> +++ b/drivers/timer/altera_timer.c
> @@ -16,6 +16,11 @@
>
> DECLARE_GLOBAL_DATA_PTR;
>
> +/* control register */
> +#define ALTERA_TIMER_CONT BIT(1) /* Continuous mode */
> +#define ALTERA_TIMER_START BIT(2) /* Start timer */
> +#define ALTERA_TIMER_STOP BIT(3) /* Stop timer */
> +
> struct altera_timer_regs {
> u32 status; /* Timer status reg */
> u32 control; /* Timer control reg */
> @@ -30,11 +35,6 @@ struct altera_timer_platdata {
> unsigned long clock_rate;
> };
>
> -/* control register */
> -#define ALTERA_TIMER_CONT BIT(1) /* Continuous mode */
> -#define ALTERA_TIMER_START BIT(2) /* Start timer */
> -#define ALTERA_TIMER_STOP BIT(3) /* Stop timer */
> -
> static int altera_timer_get_count(struct udevice *dev, unsigned long *count)
> {
> struct altera_timer_platdata *plat = dev->platdata;
> @@ -88,7 +88,7 @@ static const struct timer_ops altera_timer_ops = {
> };
>
> static const struct udevice_id altera_timer_ids[] = {
> - { .compatible = "altr,timer-1.0", },
> + { .compatible = "altr,timer-1.0" },
> { }
> };
>
>
next prev parent reply other threads:[~2015-11-03 5:21 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-30 7:18 [U-Boot] [PATCH 1/8] serial: altera_jtag_uart: use BIT macro Thomas Chou
2015-10-30 7:18 ` [U-Boot] [PATCH 2/8] serial: altera_jtag_uart: minor clean up Thomas Chou
2015-10-30 8:09 ` Jagan Teki
2015-11-03 5:20 ` Thomas Chou
2015-10-30 7:18 ` [U-Boot] [PATCH 3/8] serial: altera_uart: use BIT macro Thomas Chou
2015-10-30 8:10 ` Jagan Teki
2015-11-03 5:20 ` Thomas Chou
2015-10-30 7:18 ` [U-Boot] [PATCH 4/8] serial: altera_uart: minor clean up Thomas Chou
2015-10-30 8:12 ` Jagan Teki
2015-11-03 5:21 ` Thomas Chou
2015-10-30 7:18 ` [U-Boot] [PATCH 5/8] timer: altera_timer: use BIT macro Thomas Chou
2015-10-30 8:13 ` Jagan Teki
2015-11-03 5:21 ` Thomas Chou
2015-10-30 7:18 ` [U-Boot] [PATCH 6/8] timer: altera_timer: minor clean up Thomas Chou
2015-10-30 8:13 ` Jagan Teki
2015-11-03 5:21 ` Thomas Chou [this message]
2015-10-30 7:18 ` [U-Boot] [PATCH 7/8] misc: altera_sysid: " Thomas Chou
2015-10-30 8:14 ` Jagan Teki
2015-11-03 5:21 ` Thomas Chou
2015-10-30 7:18 ` [U-Boot] [PATCH 8/8] spi: altera_spi: " Thomas Chou
2015-10-30 8:15 ` Jagan Teki
2015-11-03 5:22 ` Thomas Chou
2015-10-30 8:07 ` [U-Boot] [PATCH 1/8] serial: altera_jtag_uart: use BIT macro Jagan Teki
2015-11-03 5:19 ` Thomas Chou
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5638445D.8060908@wytron.com.tw \
--to=thomas@wytron.com.tw \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox