[U-Boot] [PATCH v2 5/5] board: ti: AM57xx: Add detection logic for AM57xx-evm

Steven Kipisz
2015-11-03T15:36:24Z

On 11/03/2015 09:31 AM, Nishanth Menon wrote:
> On 11/03/2015 06:22 AM, Steve Kipisz wrote:
>> diff --git a/include/configs/ti_omap5_common.h b/include/configs/ti_omap5_common.h
>> index 5acbc92c3f60..ae6e2a556a93 100644
>> --- a/include/configs/ti_omap5_common.h
>> +++ b/include/configs/ti_omap5_common.h
>> @@ -120,6 +120,8 @@
>> "setenv fdtfile dra72-evm.dtb; fi;" \
>> "if test $board_name = beagle_x15; then " \
>> "setenv fdtfile am57xx-beagle-x15.dtb; fi;" \
>> + "if test $board_name = am57xx_evm; then " \
>> + "setenv fdtfile am57xx-evm.dtb; fi;" \
>> "if test $fdtfile = undefined; then " \
>> "echo WARNING: Could not determine device tree to use; fi; \0" \
>> "loadfdt=load mmc ${bootpart} ${fdtaddr} ${bootdir}/${fdtfile};\0" \
>
> Hmmm.... I might keep this nugget out of upstream code for now.
> https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/tree/arch/arm/boot/dts/
> does not contain am57xx-evm.
>
> it is possible that when we post patches upstream, it might become dt
> overlay instead of evm dtb. I dont know about what will eventually
> become in upstream. So, I suggest dropping the above change.
>
>
Got it.
>
> Also, in the future, could you cc beagleboard-x15
> <beagleboard-x15@googlegroups.com> for all patches that impact
> beagleboard-X15 I am sure folks there will be interested to review as well?
>
Ok. I'll add it to my send-email script.

Steve K.