From: Przemyslaw Marczak <p.marczak@samsung.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] please pull u-boot-samsung master
Date: Wed, 04 Nov 2015 18:12:39 +0100 [thread overview]
Message-ID: <563A3C87.9050904@samsung.com> (raw)
In-Reply-To: <CALrBrZ1_qFA9uynrg5917cpEQGwgusCwUCiPSoUYUPMnvDes4A@mail.gmail.com>
Hello Minkyu,
On 11/04/2015 04:43 PM, Minkyu Kang wrote:
> Dear Przemyslaw Marczak,
>
> On 4 November 2015 at 18:37, Przemyslaw Marczak <p.marczak@samsung.com
> <mailto:p.marczak@samsung.com>> wrote:
>
> Hello Minkyu,
>
> On 11/04/2015 03:05 AM, Minkyu Kang wrote:
>
> Dear Przemyslaw Marczak,
>
> 2015? 11? 4? ???, Tom Rini<trini@konsulko.com
> <mailto:trini@konsulko.com>
>
> On Tue, Nov 03, 2015 at 02:02:57PM +0900, Minkyu Kang wrote:
>
> > Dear Tom,
> >
> > The following changes since commit
> 0e067a65f57189703668826d9841fea477026bf6:
> >
> > x86: Select the ns16550 debug UART for minnowmax,
> chromebook_link (2015-10-30 18:04:14 -0400)
> >
> > are available in the git repository at:
> >
> > http://git.denx.de/u-boot-samsung
> >
> > for you to fetch changes up to
> de5f9733f653091d4b227914d04432099a6448dc:
> >
> > samsung: clean up checkpatch issues (2015-11-02
> 10:38:22 +0900)
> >
>
> NAK:
>
> +(sandbox) ../drivers/adc/sandbox.c:11:25: fatal error:
> sandbox-adc.h: No such file or directory
> +(sandbox) #include <sandbox-adc.h>
> +(sandbox) ^
> +(sandbox) compilation terminated.
> +(sandbox) make[3]: *** [drivers/adc/sandbox.o] Error 1
> +(sandbox) make[2]: *** [drivers/adc] Error 2
> +(sandbox) make[1]: *** [drivers] Error 2
>
> "sandbox: add ADC unit tests" is missing adding sandbox-adc.h
>
>
> Could you please check it?
>
> --
> Tom
>
>
> Thanks,
> Minkyu Kang.
>
>
> --
> Thanks.
> Minkyu Kang.
>
>
> Sorry for this mistake. I have this file locally, so it build
> properly for me.
>
> Is that good to you if I send you a patch with this missing file, to
> squash with one commit? Or do you prefer V3 of the whole patch-set?
>
>
> If squash your patch then I should do push forced.
> I think it's not a good way.
> I will merge your patch separately.
>
> Thanks,
> Minkyu Kang.
> --
> from. prom.
> www.promsoft.net <http://www.promsoft.net>
Squashing would be better if we want prevent build break. This single
file (include/sandbox-adc.h) will not conflict with any other, so it's
easy to rebase it.
This is not a master tree, so I think that push with force will not
cause any problems.
But if you really prefer to take it as a separate patch, then I will
send one, with a proper commit message in a moment.
Best regards,
--
Przemyslaw Marczak
Samsung R&D Institute Poland
Samsung Electronics
p.marczak at samsung.com
next prev parent reply other threads:[~2015-11-04 17:12 UTC|newest]
Thread overview: 168+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-03 5:02 [U-Boot] please pull u-boot-samsung master Minkyu Kang
2015-11-03 16:09 ` Tom Rini
2015-11-04 2:05 ` Minkyu Kang
2015-11-04 9:37 ` Przemyslaw Marczak
2015-11-04 15:43 ` Minkyu Kang
2015-11-04 17:12 ` Przemyslaw Marczak [this message]
2015-11-04 17:30 ` [U-Boot] [PATCH] sandbox: adc: Add missing header file Przemyslaw Marczak
2015-11-05 6:33 ` Minkyu Kang
-- strict thread matches above, loose matches on Subject: below --
2019-09-06 8:42 [U-Boot] please pull u-boot-samsung master Minkyu Kang
2019-09-06 23:26 ` Tom Rini
[not found] <CGME20190516101733epcas1p217a434a2f68fddccd84bc49f8b8aadaa@epcas1p2.samsung.com>
2019-05-16 10:17 ` Minkyu Kang
2019-05-17 11:15 ` Tom Rini
[not found] <CGME20190312082337epcas1p42f7881315d62e035434635fc48e72ee8@epcas1p4.samsung.com>
2019-03-12 8:23 ` Minkyu Kang
2019-03-14 0:32 ` Tom Rini
2019-03-14 9:46 ` Krzysztof Kozlowski
[not found] <CGME20181227034953epcas1p4fdf3b45773d658ac797be9ad7bc72451@epcas1p4.samsung.com>
2018-12-27 3:49 ` Minkyu Kang
2018-12-27 15:41 ` Tom Rini
2018-12-28 1:58 ` Minkyu Kang
[not found] <CGME20181024011258epcas1p129d111a207f8facad2e2198f01e354d2@epcas1p1.samsung.com>
2018-10-24 1:12 ` Minkyu Kang
2018-10-24 13:32 ` Tom Rini
[not found] <CGME20180808003737epcas1p13b402f999609bfbee8bcf85776fa1131@epcas1p1.samsung.com>
2018-08-08 0:37 ` Minkyu Kang
2018-08-09 0:02 ` Tom Rini
2018-06-06 12:55 Minkyu Kang
2018-06-06 15:09 ` Tom Rini
2018-06-07 1:36 ` Minkyu Kang
[not found] <CGME20171213044325epcas1p2403e377b4588aafbe4d0caad37934bbc@epcas1p2.samsung.com>
[not found] ` <8a8b2945-07c4-dcb8-4a3f-e07deb508f9c@samsung.com>
2017-12-13 4:43 ` Jaehoon Chung
2017-12-14 20:45 ` Tom Rini
2017-11-06 14:21 Minkyu Kang
2017-11-06 14:25 ` Tom Rini
[not found] <CGME20170621010007epcas5p4f6ab04e8b3c479ba8eee6e42c1b14bd2@epcas5p4.samsung.com>
2017-06-21 1:00 ` Jaehoon Chung
2017-06-23 14:22 ` Minkyu Kang
2017-06-23 14:36 ` Tom Rini
2017-04-08 14:10 Minkyu Kang
2017-04-09 1:16 ` Tom Rini
2017-02-11 13:41 Minkyu Kang
2017-02-11 21:33 ` Tom Rini
[not found] <CGME20170118080722epcas5p309b73311bf43f97789ede23f57e03520@epcas5p3.samsung.com>
[not found] ` <d6099dce-30da-9dce-90f9-85e11c6c5bea@samsung.com>
2017-01-18 8:07 ` Jaehoon Chung
2017-01-18 23:14 ` Tom Rini
2016-12-23 15:07 Minkyu Kang
2016-12-23 15:17 ` Tom Rini
2016-07-15 4:17 Minkyu Kang
2016-07-16 13:51 ` Tom Rini
2016-06-27 7:13 Minkyu Kang
2016-06-28 1:12 ` Tom Rini
2016-05-26 5:03 Minkyu Kang
2016-05-26 14:52 ` Tom Rini
2016-05-30 2:31 ` Minkyu Kang
2016-05-30 2:39 ` Simon Glass
2016-06-10 6:03 ` Minkyu Kang
2016-06-10 11:09 ` Tom Rini
2016-06-14 7:58 ` Minkyu Kang
2016-04-26 7:45 Minkyu Kang
2016-04-26 11:20 ` Tom Rini
2016-03-11 11:37 Minkyu Kang
2016-03-11 17:07 ` Tom Rini
2015-11-30 8:33 Minkyu Kang
2015-11-30 20:17 ` Tom Rini
2015-10-16 7:51 Minkyu Kang
2015-10-17 0:21 ` Tom Rini
2015-08-18 2:22 Minkyu Kang
2015-08-18 14:47 ` Tom Rini
2015-07-10 12:16 Minkyu Kang
2015-07-10 19:02 ` Tom Rini
2015-06-11 1:43 Minkyu Kang
2015-06-11 1:46 ` Tom Rini
2015-05-18 11:52 Minkyu Kang
2015-05-18 23:54 ` Tom Rini
2015-04-06 6:38 Minkyu Kang
2015-04-06 22:12 ` Tom Rini
2015-04-08 13:40 ` Lukasz Majewski
2015-03-04 12:11 Minkyu Kang
2015-02-28 10:06 Minkyu Kang
2015-03-02 1:04 ` Simon Glass
2015-03-02 2:07 ` Tom Rini
2015-03-02 2:21 ` Minkyu Kang
2015-03-02 12:23 ` Tom Rini
2015-02-28 9:56 Minkyu Kang
2015-02-28 9:51 Minkyu Kang
2015-02-13 8:31 Minkyu Kang
2015-02-13 15:13 ` Simon Glass
2015-02-17 10:43 ` Minkyu Kang
2015-02-16 17:41 ` Tom Rini
2014-12-30 9:19 Minkyu Kang
2015-01-01 14:55 ` Tom Rini
2014-11-25 12:28 Minkyu Kang
2014-11-26 16:24 ` Tom Rini
2014-11-04 10:57 Minkyu Kang
2014-11-04 20:00 ` Tom Rini
2014-10-08 11:36 Minkyu Kang
2014-10-08 19:13 ` Albert ARIBAUD
2014-10-10 0:15 ` Minkyu Kang
2014-10-10 9:38 ` Albert ARIBAUD
2014-09-05 12:30 Minkyu Kang
2014-09-08 23:03 ` Albert ARIBAUD
2014-06-30 8:42 Minkyu Kang
2014-07-01 19:34 ` Albert ARIBAUD
2014-05-31 5:29 Minkyu Kang
2014-06-02 7:28 ` Albert ARIBAUD
2014-05-13 10:47 Minkyu Kang
2014-05-15 14:28 ` Albert ARIBAUD
2014-05-16 1:02 ` Minkyu Kang
2014-05-15 15:18 ` Albert ARIBAUD
2014-04-02 12:55 Minkyu Kang
2014-04-02 17:57 ` Albert ARIBAUD
2014-03-13 6:10 Minkyu Kang
2014-03-14 6:30 ` Albert ARIBAUD
2014-02-13 12:27 Minkyu Kang
2014-02-13 13:06 ` Albert ARIBAUD
2014-01-03 5:30 Minkyu Kang
2014-01-06 9:10 ` Albert ARIBAUD
2013-12-05 8:11 Minkyu Kang
2013-12-06 9:39 ` Albert ARIBAUD
2013-10-10 1:46 Minkyu Kang
2013-10-11 13:49 ` Albert ARIBAUD
2013-09-11 2:28 Minkyu Kang
2013-09-11 13:05 ` Albert ARIBAUD
2013-08-30 5:10 Minkyu Kang
2013-09-05 9:13 ` Albert ARIBAUD
2013-09-05 9:42 ` Chander Kashyap
2013-09-05 9:59 ` Chander Kashyap
2013-09-05 10:57 ` Lukasz Majewski
2013-09-05 11:17 ` Chander Kashyap
2013-09-05 11:38 ` Albert ARIBAUD
2013-09-05 12:06 ` Chander Kashyap
2013-09-05 13:28 ` Albert ARIBAUD
2013-09-06 4:32 ` Chander Kashyap
2013-09-09 8:25 ` Minkyu Kang
2013-09-10 7:54 ` Chander Kashyap
2013-07-10 12:24 Minkyu Kang
2013-07-10 20:26 ` Albert ARIBAUD
2013-07-05 10:08 Minkyu Kang
2013-07-05 19:12 ` Albert ARIBAUD
2013-07-07 5:43 ` Minkyu Kang
2013-07-09 8:14 ` Minkyu Kang
2013-06-17 2:10 Minkyu Kang
2013-06-17 7:46 ` Jagan Teki
2013-06-18 14:57 ` Albert ARIBAUD
2013-06-19 0:39 ` Minkyu Kang
2013-06-19 11:49 ` Jagan Teki
2013-06-19 11:54 ` Albert ARIBAUD
2013-06-19 12:07 ` Jagan Teki
2013-06-19 11:30 ` Albert ARIBAUD
2013-06-19 12:11 ` Minkyu Kang
2013-06-19 15:59 ` Albert ARIBAUD
2013-04-17 2:13 Minkyu Kang
2013-04-17 14:23 ` Albert ARIBAUD
2013-04-04 13:34 Minkyu Kang
2013-04-04 14:12 ` Albert ARIBAUD
2013-03-21 9:54 Minkyu Kang
2013-03-26 8:50 ` Albert ARIBAUD
2013-03-26 9:37 ` Albert ARIBAUD
2013-01-11 8:23 Minkyu Kang
2013-01-11 21:33 ` Albert ARIBAUD
2013-01-12 8:01 ` Albert ARIBAUD
2013-01-14 4:46 ` Rajeshwari Birje
2013-01-14 7:44 ` Albert ARIBAUD
2013-01-14 9:18 ` Ajay kumar
2013-01-14 4:56 ` Minkyu Kang
2013-01-14 7:32 ` Albert ARIBAUD
2012-11-15 12:12 Minkyu Kang
2012-11-15 23:50 ` Albert ARIBAUD
2012-11-16 6:40 ` Minkyu Kang
2012-11-16 20:58 ` Albert ARIBAUD
2012-10-10 12:16 Minkyu Kang
2012-10-11 16:50 ` Albert ARIBAUD
2012-10-12 5:35 ` Albert ARIBAUD
2012-08-27 4:24 Minkyu Kang
2012-09-01 11:48 ` Albert ARIBAUD
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=563A3C87.9050904@samsung.com \
--to=p.marczak@samsung.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox