public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Daniel Schwierzeck <daniel.schwierzeck@gmail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 1/4] mips: Use the generic bitops headers
Date: Wed, 4 Nov 2015 18:58:27 +0100	[thread overview]
Message-ID: <563A4743.7050308@gmail.com> (raw)
In-Reply-To: <1446657237-27091-1-git-send-email-festevam@gmail.com>



Am 04.11.2015 um 18:13 schrieb Fabio Estevam:
> From: Fabio Estevam <fabio.estevam@freescale.com>
> 
> The generic bitops headers are required when calling logarithimic
> functions, such as ilog2().
> 
> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
> ---
> Applies against u-boot-spi next
> 
>  arch/mips/include/asm/bitops.h | 5 +++++
>  1 file changed, 5 insertions(+)
> 

Reviewed-by: Daniel Schwierzeck <daniel.schwierzeck@gmail.com>

--
After applying your patches

include: Add log2 header from the kernel
include: Add generic bitops headers

I've got warnings on almost all MIPS boards. Maybe you should move your
modification on "include/linux/bitops.h" in the second patch to a
separate patch to be applied after all arch-specific patches to avoid
this. I guess the other archs have the same problem.

-- 
- Daniel

  parent reply	other threads:[~2015-11-04 17:58 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-04 17:13 [U-Boot] [PATCH 1/4] mips: Use the generic bitops headers Fabio Estevam
2015-11-04 17:13 ` [U-Boot] [PATCH 2/4] arc: " Fabio Estevam
2015-11-04 17:13 ` [U-Boot] [PATCH 3/4] avr32: " Fabio Estevam
2015-11-04 17:13 ` [U-Boot] [PATCH 4/4] spi: sf_ops: Use size_t for len Fabio Estevam
2015-11-04 17:21 ` [U-Boot] [PATCH 1/4] mips: Use the generic bitops headers Dinh Nguyen
2015-11-05 13:21   ` Fabio Estevam
2015-11-04 17:58 ` Daniel Schwierzeck [this message]
2015-11-05 13:21   ` Fabio Estevam

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=563A4743.7050308@gmail.com \
    --to=daniel.schwierzeck@gmail.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox