From: Nishanth Menon <nm@ti.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v3 3/5] ARM: omap-common: Add standard access for board description EEPROM
Date: Wed, 4 Nov 2015 22:50:52 -0600 [thread overview]
Message-ID: <563AE02C.3010302@ti.com> (raw)
In-Reply-To: <563A982D.6020109@ti.com>
On 11/04/2015 05:43 PM, Nishanth Menon wrote:
[...]
>> index 5cd6873f5e97..9d85d31b2cf1 100644
>> --- a/board/ti/am57xx/Makefile
>> +++ b/board/ti/am57xx/Makefile
>> @@ -6,3 +6,5 @@
>> #
>>
>> obj-y := board.o
>> +obj-y += ../common/board.o
>
One final comment on the ../common/board.o:
all we need is:
board/ti/common/Makefile
which contains:
obj-${CONFIG_I2C} += board-detect.o
That should build it for all TI platforms and then optimize link time
using __maybe_unused.
This also removes the cruft of including specific headers since root
Makefile already will enable flag HAVE_VENDOR_COMMON_LIB if a Makefile
exists in board/{vendor}/common/ directory, and will build accordingly.
This makes sense now since the entire series claims commonality and
should allow us to remove stuff from am335x/437x following this series
by just using the APIs.
--
Regards,
Nishanth Menon
next prev parent reply other threads:[~2015-11-05 4:50 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-04 22:00 [U-Boot] [PATCH v3 0/5] ARM: omap-common: Add board detection support for TI EVMs Steve Kipisz
2015-11-04 22:00 ` [U-Boot] [PATCH v3 1/5] ARM: OMAP4/5: Centralize early clock initialization Steve Kipisz
2015-11-05 5:45 ` Lokesh Vutla
2015-11-04 22:00 ` [U-Boot] [PATCH v3 2/5] ARM: OMAP4/5: Centralize gpi2c_init Steve Kipisz
2015-11-05 5:46 ` Lokesh Vutla
2015-11-04 22:00 ` [U-Boot] [PATCH v3 3/5] ARM: omap-common: Add standard access for board description EEPROM Steve Kipisz
2015-11-04 23:43 ` Nishanth Menon
2015-11-05 4:50 ` Nishanth Menon [this message]
2015-11-05 6:00 ` Lokesh Vutla
2015-11-05 7:21 ` Nishanth Menon
2015-11-04 22:00 ` [U-Boot] [PATCH v3 4/5] ARM: OMAP4/5: Add generic board detection hook Steve Kipisz
2015-11-05 5:49 ` Lokesh Vutla
2015-11-04 22:00 ` [U-Boot] [PATCH v3 5/5] board: ti: AM57xx: Add detection logic for AM57xx-evm Steve Kipisz
2015-11-04 23:53 ` [U-Boot] [PATCH v3 0/5] ARM: omap-common: Add board detection support for TI EVMs Nishanth Menon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=563AE02C.3010302@ti.com \
--to=nm@ti.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox