public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Thomas Chou <thomas@wytron.com.tw>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 2/2] nios2: trim CONFIG_SYS_MEMTEST_END
Date: Thu, 5 Nov 2015 13:47:42 +0800	[thread overview]
Message-ID: <563AED7E.7030503@wytron.com.tw> (raw)
In-Reply-To: <1446647249.2582.3.camel@clsee-VirtualBox>

Hi Chin Liang,

On 2015?11?04? 22:27, Chin Liang See wrote:
>> +#define CONFIG_SYS_MEMTEST_END		(CONFIG_SYS_MONITOR_BASE - \
>> +					 CONFIG_ENV_SIZE - \
>> +					 CONFIG_SYS_MALLOC_LEN -	\
>
> Since CONFIG_ENV_IS_IN_FLASH, I believe we can take out the
> CONFIG_ENV_SIZE here.
>

This comes from a very old macro in common.h,

#if defined(CONFIG_ENV_IS_EMBEDDED)
#define TOTAL_MALLOC_LEN	CONFIG_SYS_MALLOC_LEN
#elif ( ((CONFIG_ENV_ADDR+CONFIG_ENV_SIZE) < CONFIG_SYS_MONITOR_BASE) || \
	(CONFIG_ENV_ADDR >= (CONFIG_SYS_MONITOR_BASE + CONFIG_SYS_MONITOR_LEN)) 
) || \
       defined(CONFIG_ENV_IS_IN_NVRAM)
#define	TOTAL_MALLOC_LEN	(CONFIG_SYS_MALLOC_LEN + CONFIG_ENV_SIZE)
#else
#define	TOTAL_MALLOC_LEN	CONFIG_SYS_MALLOC_LEN
#endif

The TOTAL_MALLOC_LEN is (CONFIG_SYS_MALLOC_LEN + CONFIG_ENV_SIZE) for 
nios2. I think the macro might need fix though.

Best regards,
Thomas

  reply	other threads:[~2015-11-05  5:47 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-04  5:30 [U-Boot] [PATCH 1/2] nios2: trim CONFIG_SYS_MALLOC_LEN Thomas Chou
2015-11-04  5:30 ` [U-Boot] [PATCH 2/2] nios2: trim CONFIG_SYS_MEMTEST_END Thomas Chou
2015-11-04 14:27   ` Chin Liang See
2015-11-05  5:47     ` Thomas Chou [this message]
2015-11-09  6:37       ` Chin Liang See
2015-11-06  1:30   ` Thomas Chou
2015-11-04 14:22 ` [U-Boot] [PATCH 1/2] nios2: trim CONFIG_SYS_MALLOC_LEN Chin Liang See
2015-11-06  1:30 ` Thomas Chou

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=563AED7E.7030503@wytron.com.tw \
    --to=thomas@wytron.com.tw \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox