[U-Boot] Riotboard FEC broken

[U-Boot] Riotboard FEC broken

[Catalin Crenguta]

Hello,

I have ran git bisect commit and found out that commit
59370f3fcd135089c402c93720a87c688abe600c breaks FEC on Riotboard.
Reverting this change makes it working again.

Full log below:
git bisect start
# bad: [5ec0003b19cbdf06ccd6941237cbc0d1c3468e2d] Prepare v2015.10
git bisect bad 5ec0003b19cbdf06ccd6941237cbc0d1c3468e2d
# good: [f33cdaa4c3da4a8fd35aa2f9a3172f31cc887b35] Prepare v2015.04
git bisect good f33cdaa4c3da4a8fd35aa2f9a3172f31cc887b35
# good: [8ed43b966ccf7f1153f553dce86de60a6e0e9d9a] arm: mvebu: Add SPL
SDIO/MMC boot support
git bisect good 8ed43b966ccf7f1153f553dce86de60a6e0e9d9a
# bad: [ce2cb1d3ed92e91b24db516802be3688f7c28e26] arm: mvebu:
db-88f6820-gp: Enable PCI support
git bisect bad ce2cb1d3ed92e91b24db516802be3688f7c28e26
# good: [9bbd2132e3af95ac225f3641b69bd129da11457f] driver/ddr/altera:
Add DDR driver for Altera's SDRAM controller
git bisect good 9bbd2132e3af95ac225f3641b69bd129da11457f
# good: [15f8876b1dd95dd6bcee686ada36369871bbcdc9] Merge branch
'master' of http://git.denx.de/u-boot-sunxi
git bisect good 15f8876b1dd95dd6bcee686ada36369871bbcdc9
# bad: [fcd78fa604d994477fd209b9faab4a974b103250] Merge branch
'master' of git://git.denx.de/u-boot-net
git bisect bad fcd78fa604d994477fd209b9faab4a974b103250
# good: [3f394e70f0cc31a5d63d3650fd4f48e450ea16cd] integrator: switch
to DM serial port
git bisect good 3f394e70f0cc31a5d63d3650fd4f48e450ea16cd
# good: [b5d92ba1ad97c06985ebc689e1ac1462a146832d] ARM: SPL: Use
CONFIG_SPL_DM not CONFIG_DM
git bisect good b5d92ba1ad97c06985ebc689e1ac1462a146832d
# bad: [59370f3fcd135089c402c93720a87c688abe600c] net: phy: delay only
if reset handler is registered
git bisect bad 59370f3fcd135089c402c93720a87c688abe600c
# good: [8396d0ab8b46907bd89e9f3a35fbb727f077d28a] net: Add support
for Marvell 88E1510 PHY
git bisect good 8396d0ab8b46907bd89e9f3a35fbb727f077d28a
# good: [23f5db0e26f0e6c25ba143e700b4812efdd5f941] net: lpc32xx:
improve MAC configuration on reset and initialization
git bisect good 23f5db0e26f0e6c25ba143e700b4812efdd5f941
# good: [466f775e02bcde5ea7454cd73ecf1a0f79275a30] qoriq eth.c bugfix:
handle received corrupted frames correctly
git bisect good 466f775e02bcde5ea7454cd73ecf1a0f79275a30
# good: [2c171a2a5fc0865501a2e5043e9728036dac6dc3] net: phy: fix data
type of phy_id
git bisect good 2c171a2a5fc0865501a2e5043e9728036dac6dc3
# first bad commit: [59370f3fcd135089c402c93720a87c688abe600c] net:
phy: delay only if reset handler is registered

Best regards,
Catalin Crenguta

[U-Boot] Riotboard FEC broken

[Fabio Estevam]

On Thu, Nov 5, 2015 at 9:10 AM, Catalin Crenguta
<catalin.crenguta@gmail.com> wrote:
> Hello,
>
> I have ran git bisect commit and found out that commit
> 59370f3fcd135089c402c93720a87c688abe600c breaks FEC on Riotboard.
> Reverting this change makes it working again.

I can confirm this. Thanks for running git bisect and reporting it.

Adding J?rg and Joe on Cc.

[U-Boot] Riotboard FEC broken

[Stefan Roese]

Hi Catalin, Hi Fabio,

On 05.11.2015 14:04, Fabio Estevam wrote:
> On Thu, Nov 5, 2015 at 9:10 AM, Catalin Crenguta
> <catalin.crenguta@gmail.com> wrote:
>> Hello,
>>
>> I have ran git bisect commit and found out that commit
>> 59370f3fcd135089c402c93720a87c688abe600c breaks FEC on Riotboard.
>> Reverting this change makes it working again.
> 
> I can confirm this. Thanks for running git bisect and reporting it.
> 
> Adding J?rg and Joe on Cc.

I've just checked the Riotboard code for PHY reset handling. And
found this:

static void setup_iomux_enet(void)
{
	imx_iomux_v3_setup_multiple_pads(enet_pads, ARRAY_SIZE(enet_pads));

	/* Reset AR8035 PHY */
	gpio_direction_output(IMX_GPIO_NR(3, 31) , 0);
	mdelay(2);
	gpio_set_value(IMX_GPIO_NR(3, 31), 1);
}

If this PHY needs a delay after deasserting the reset here, then you
should add it in this function (please check the manual for the exact
value). This just used to work before commit
59370f3fcd135089c402c93720a87c688abe600c since you were lucky that
this 15ms delay was added in phy_find_by_mask(). Now its gone and
your PHY is still not out of reset, triggered in setup_iomux_enet().

Thanks,
Stefan

[U-Boot] Riotboard FEC broken

[Fabio Estevam]

Hi Catalin,

On Thu, Nov 5, 2015 at 9:10 AM, Catalin Crenguta
<catalin.crenguta@gmail.com> wrote:
> Hello,
>
> I have ran git bisect commit and found out that commit
> 59370f3fcd135089c402c93720a87c688abe600c breaks FEC on Riotboard.
> Reverting this change makes it working again.

Does this changes fix the problem?

--- a/board/embest/mx6boards/mx6boards.c
+++ b/board/embest/mx6boards/mx6boards.c
@@ -118,7 +118,7 @@ static void setup_iomux_enet(void)

        /* Reset AR8035 PHY */
        gpio_direction_output(IMX_GPIO_NR(3, 31) , 0);
-       mdelay(2);
+       mdelay(10);
        gpio_set_value(IMX_GPIO_NR(3, 31), 1);
 }

Regards,

Fabio Estevam