* [U-Boot] [PATCH 1/2] altera_jtag_uart: Adjust the declaration of debug_uart_init()
@ 2015-11-03 6:19 Thomas Chou
2015-11-03 6:19 ` [U-Boot] [PATCH 2/2] altera_uart: " Thomas Chou
` (3 more replies)
0 siblings, 4 replies; 10+ messages in thread
From: Thomas Chou @ 2015-11-03 6:19 UTC (permalink / raw)
To: u-boot
Follow commit 97b059730218 ("debug_uart: Adjust the declaration of
debug_uart_init()")
Signed-off-by: Thomas Chou <thomas@wytron.com.tw>
---
drivers/serial/altera_jtag_uart.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/serial/altera_jtag_uart.c b/drivers/serial/altera_jtag_uart.c
index 767603c..5f0d7ac 100644
--- a/drivers/serial/altera_jtag_uart.c
+++ b/drivers/serial/altera_jtag_uart.c
@@ -130,7 +130,7 @@ U_BOOT_DRIVER(altera_jtaguart) = {
#include <debug_uart.h>
-void debug_uart_init(void)
+void _debug_uart_init(void)
{
}
--
2.5.0
^ permalink raw reply related [flat|nested] 10+ messages in thread
* [U-Boot] [PATCH 2/2] altera_uart: Adjust the declaration of debug_uart_init()
2015-11-03 6:19 [U-Boot] [PATCH 1/2] altera_jtag_uart: Adjust the declaration of debug_uart_init() Thomas Chou
@ 2015-11-03 6:19 ` Thomas Chou
2015-11-03 15:22 ` Marek Vasut
` (2 more replies)
2015-11-03 15:22 ` [U-Boot] [PATCH 1/2] altera_jtag_uart: " Marek Vasut
` (2 subsequent siblings)
3 siblings, 3 replies; 10+ messages in thread
From: Thomas Chou @ 2015-11-03 6:19 UTC (permalink / raw)
To: u-boot
Follow commit 97b059730218 ("debug_uart: Adjust the declaration of
debug_uart_init()")
Signed-off-by: Thomas Chou <thomas@wytron.com.tw>
---
drivers/serial/altera_uart.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/serial/altera_uart.c b/drivers/serial/altera_uart.c
index 4c4794e..6228981 100644
--- a/drivers/serial/altera_uart.c
+++ b/drivers/serial/altera_uart.c
@@ -124,7 +124,7 @@ U_BOOT_DRIVER(altera_uart) = {
#include <debug_uart.h>
-void debug_uart_init(void)
+void _debug_uart_init(void)
{
struct altera_uart_regs *regs = (void *)CONFIG_DEBUG_UART_BASE;
u32 div;
--
2.5.0
^ permalink raw reply related [flat|nested] 10+ messages in thread
* [U-Boot] [PATCH 1/2] altera_jtag_uart: Adjust the declaration of debug_uart_init()
2015-11-03 6:19 [U-Boot] [PATCH 1/2] altera_jtag_uart: Adjust the declaration of debug_uart_init() Thomas Chou
2015-11-03 6:19 ` [U-Boot] [PATCH 2/2] altera_uart: " Thomas Chou
@ 2015-11-03 15:22 ` Marek Vasut
2015-11-04 7:27 ` Chin Liang See
2015-11-06 1:28 ` Thomas Chou
3 siblings, 0 replies; 10+ messages in thread
From: Marek Vasut @ 2015-11-03 15:22 UTC (permalink / raw)
To: u-boot
On Tuesday, November 03, 2015 at 07:19:34 AM, Thomas Chou wrote:
> Follow commit 97b059730218 ("debug_uart: Adjust the declaration of
> debug_uart_init()")
>
> Signed-off-by: Thomas Chou <thomas@wytron.com.tw>
Reviewed-by: Marek Vasut <marex@denx.de>
> ---
> drivers/serial/altera_jtag_uart.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/serial/altera_jtag_uart.c
> b/drivers/serial/altera_jtag_uart.c index 767603c..5f0d7ac 100644
> --- a/drivers/serial/altera_jtag_uart.c
> +++ b/drivers/serial/altera_jtag_uart.c
> @@ -130,7 +130,7 @@ U_BOOT_DRIVER(altera_jtaguart) = {
>
> #include <debug_uart.h>
>
> -void debug_uart_init(void)
> +void _debug_uart_init(void)
> {
> }
Best regards,
Marek Vasut
^ permalink raw reply [flat|nested] 10+ messages in thread
* [U-Boot] [PATCH 2/2] altera_uart: Adjust the declaration of debug_uart_init()
2015-11-03 6:19 ` [U-Boot] [PATCH 2/2] altera_uart: " Thomas Chou
@ 2015-11-03 15:22 ` Marek Vasut
2015-11-04 7:28 ` Chin Liang See
2015-11-06 1:28 ` Thomas Chou
2 siblings, 0 replies; 10+ messages in thread
From: Marek Vasut @ 2015-11-03 15:22 UTC (permalink / raw)
To: u-boot
On Tuesday, November 03, 2015 at 07:19:35 AM, Thomas Chou wrote:
> Follow commit 97b059730218 ("debug_uart: Adjust the declaration of
> debug_uart_init()")
>
> Signed-off-by: Thomas Chou <thomas@wytron.com.tw>
Reviewed-by: Marek Vasut <marex@denx.de>
> ---
> drivers/serial/altera_uart.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/serial/altera_uart.c b/drivers/serial/altera_uart.c
> index 4c4794e..6228981 100644
> --- a/drivers/serial/altera_uart.c
> +++ b/drivers/serial/altera_uart.c
> @@ -124,7 +124,7 @@ U_BOOT_DRIVER(altera_uart) = {
>
> #include <debug_uart.h>
>
> -void debug_uart_init(void)
> +void _debug_uart_init(void)
> {
> struct altera_uart_regs *regs = (void *)CONFIG_DEBUG_UART_BASE;
> u32 div;
Best regards,
Marek Vasut
^ permalink raw reply [flat|nested] 10+ messages in thread
* [U-Boot] [PATCH 1/2] altera_jtag_uart: Adjust the declaration of debug_uart_init()
2015-11-03 6:19 [U-Boot] [PATCH 1/2] altera_jtag_uart: Adjust the declaration of debug_uart_init() Thomas Chou
2015-11-03 6:19 ` [U-Boot] [PATCH 2/2] altera_uart: " Thomas Chou
2015-11-03 15:22 ` [U-Boot] [PATCH 1/2] altera_jtag_uart: " Marek Vasut
@ 2015-11-04 7:27 ` Chin Liang See
2015-11-06 1:28 ` Thomas Chou
3 siblings, 0 replies; 10+ messages in thread
From: Chin Liang See @ 2015-11-04 7:27 UTC (permalink / raw)
To: u-boot
On Tue, 2015-11-03 at 14:19 +0800, thomas at wytron.com.tw wrote:
> Follow commit 97b059730218 ("debug_uart: Adjust the declaration of
> debug_uart_init()")
>
> Signed-off-by: Thomas Chou <thomas@wytron.com.tw>
> ---
Reviewed-by: Chin Liang See <clsee@altera.com>
Thanks
Chin Liang
^ permalink raw reply [flat|nested] 10+ messages in thread
* [U-Boot] [PATCH 2/2] altera_uart: Adjust the declaration of debug_uart_init()
2015-11-03 6:19 ` [U-Boot] [PATCH 2/2] altera_uart: " Thomas Chou
2015-11-03 15:22 ` Marek Vasut
@ 2015-11-04 7:28 ` Chin Liang See
2015-11-06 1:28 ` Thomas Chou
2 siblings, 0 replies; 10+ messages in thread
From: Chin Liang See @ 2015-11-04 7:28 UTC (permalink / raw)
To: u-boot
On Tue, 2015-11-03 at 14:19 +0800, thomas at wytron.com.tw wrote:
> Follow commit 97b059730218 ("debug_uart: Adjust the declaration of
> debug_uart_init()")
>
> Signed-off-by: Thomas Chou <thomas@wytron.com.tw>
Reviewed-by: Chin Liang See <clsee@altera.com>
Thanks
Chin Liang
^ permalink raw reply [flat|nested] 10+ messages in thread
* [U-Boot] [PATCH 1/2] altera_jtag_uart: Adjust the declaration of debug_uart_init()
2015-11-03 6:19 [U-Boot] [PATCH 1/2] altera_jtag_uart: Adjust the declaration of debug_uart_init() Thomas Chou
` (2 preceding siblings ...)
2015-11-04 7:27 ` Chin Liang See
@ 2015-11-06 1:28 ` Thomas Chou
2015-11-06 3:15 ` Simon Glass
3 siblings, 1 reply; 10+ messages in thread
From: Thomas Chou @ 2015-11-06 1:28 UTC (permalink / raw)
To: u-boot
On 2015?11?03? 14:19, Thomas Chou wrote:
> Follow commit 97b059730218 ("debug_uart: Adjust the declaration of
> debug_uart_init()")
>
> Signed-off-by: Thomas Chou <thomas@wytron.com.tw>
> ---
> drivers/serial/altera_jtag_uart.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
Applied to u-boot-nios.
> diff --git a/drivers/serial/altera_jtag_uart.c b/drivers/serial/altera_jtag_uart.c
> index 767603c..5f0d7ac 100644
> --- a/drivers/serial/altera_jtag_uart.c
> +++ b/drivers/serial/altera_jtag_uart.c
> @@ -130,7 +130,7 @@ U_BOOT_DRIVER(altera_jtaguart) = {
>
> #include <debug_uart.h>
>
> -void debug_uart_init(void)
> +void _debug_uart_init(void)
> {
> }
>
>
^ permalink raw reply [flat|nested] 10+ messages in thread
* [U-Boot] [PATCH 2/2] altera_uart: Adjust the declaration of debug_uart_init()
2015-11-03 6:19 ` [U-Boot] [PATCH 2/2] altera_uart: " Thomas Chou
2015-11-03 15:22 ` Marek Vasut
2015-11-04 7:28 ` Chin Liang See
@ 2015-11-06 1:28 ` Thomas Chou
2 siblings, 0 replies; 10+ messages in thread
From: Thomas Chou @ 2015-11-06 1:28 UTC (permalink / raw)
To: u-boot
On 2015?11?03? 14:19, Thomas Chou wrote:
> Follow commit 97b059730218 ("debug_uart: Adjust the declaration of
> debug_uart_init()")
>
> Signed-off-by: Thomas Chou <thomas@wytron.com.tw>
> ---
> drivers/serial/altera_uart.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
Applied to u-boot-nios.
> diff --git a/drivers/serial/altera_uart.c b/drivers/serial/altera_uart.c
> index 4c4794e..6228981 100644
> --- a/drivers/serial/altera_uart.c
> +++ b/drivers/serial/altera_uart.c
> @@ -124,7 +124,7 @@ U_BOOT_DRIVER(altera_uart) = {
>
> #include <debug_uart.h>
>
> -void debug_uart_init(void)
> +void _debug_uart_init(void)
> {
> struct altera_uart_regs *regs = (void *)CONFIG_DEBUG_UART_BASE;
> u32 div;
>
^ permalink raw reply [flat|nested] 10+ messages in thread
* [U-Boot] [PATCH 1/2] altera_jtag_uart: Adjust the declaration of debug_uart_init()
2015-11-06 1:28 ` Thomas Chou
@ 2015-11-06 3:15 ` Simon Glass
2015-11-06 4:35 ` Thomas Chou
0 siblings, 1 reply; 10+ messages in thread
From: Simon Glass @ 2015-11-06 3:15 UTC (permalink / raw)
To: u-boot
Hi Thomas,
On 5 November 2015 at 18:28, Thomas Chou <thomas@wytron.com.tw> wrote:
>
>
>
> On 2015?11?03? 14:19, Thomas Chou wrote:
>>
>> Follow commit 97b059730218 ("debug_uart: Adjust the declaration of
>> debug_uart_init()")
>>
>> Signed-off-by: Thomas Chou <thomas@wytron.com.tw>
>> ---
>> drivers/serial/altera_jtag_uart.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>
> Applied to u-boot-nios.
>
>
>> diff --git a/drivers/serial/altera_jtag_uart.c b/drivers/serial/altera_jtag_uart.c
>> index 767603c..5f0d7ac 100644
>> --- a/drivers/serial/altera_jtag_uart.c
>> +++ b/drivers/serial/altera_jtag_uart.c
>> @@ -130,7 +130,7 @@ U_BOOT_DRIVER(altera_jtaguart) = {
>>
>> #include <debug_uart.h>
>>
>> -void debug_uart_init(void)
>> +void _debug_uart_init(void)
BTW I think that should be static.
>> {
>> }
>>
>>
Regards,
Simon
^ permalink raw reply [flat|nested] 10+ messages in thread
* [U-Boot] [PATCH 1/2] altera_jtag_uart: Adjust the declaration of debug_uart_init()
2015-11-06 3:15 ` Simon Glass
@ 2015-11-06 4:35 ` Thomas Chou
0 siblings, 0 replies; 10+ messages in thread
From: Thomas Chou @ 2015-11-06 4:35 UTC (permalink / raw)
To: u-boot
Hi Simon,
>>> diff --git a/drivers/serial/altera_jtag_uart.c b/drivers/serial/altera_jtag_uart.c
>>> index 767603c..5f0d7ac 100644
>>> --- a/drivers/serial/altera_jtag_uart.c
>>> +++ b/drivers/serial/altera_jtag_uart.c
>>> @@ -130,7 +130,7 @@ U_BOOT_DRIVER(altera_jtaguart) = {
>>>
>>> #include <debug_uart.h>
>>>
>>> -void debug_uart_init(void)
>>> +void _debug_uart_init(void)
>
> BTW I think that should be static.
Will do. Thanks.
Best regards,
Thomas
^ permalink raw reply [flat|nested] 10+ messages in thread
end of thread, other threads:[~2015-11-06 4:35 UTC | newest]
Thread overview: 10+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-11-03 6:19 [U-Boot] [PATCH 1/2] altera_jtag_uart: Adjust the declaration of debug_uart_init() Thomas Chou
2015-11-03 6:19 ` [U-Boot] [PATCH 2/2] altera_uart: " Thomas Chou
2015-11-03 15:22 ` Marek Vasut
2015-11-04 7:28 ` Chin Liang See
2015-11-06 1:28 ` Thomas Chou
2015-11-03 15:22 ` [U-Boot] [PATCH 1/2] altera_jtag_uart: " Marek Vasut
2015-11-04 7:27 ` Chin Liang See
2015-11-06 1:28 ` Thomas Chou
2015-11-06 3:15 ` Simon Glass
2015-11-06 4:35 ` Thomas Chou
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox