public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Thomas Chou <thomas@wytron.com.tw>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v2 3/5] net: altera_tse: fix packed and aligned attribute
Date: Fri, 6 Nov 2015 09:32:04 +0800	[thread overview]
Message-ID: <563C0314.4010109@wytron.com.tw> (raw)
In-Reply-To: <1446728090-5969-3-git-send-email-thomas@wytron.com.tw>



On 2015?11?05? 20:54, Thomas Chou wrote:
> Fix packed and aligned attribute warnings.
>
> WARNING: __packed is preferred over __attribute__((packed))
> #14: FILE: drivers/net/altera_tse.h:14:
> +#define __packed_1_    __attribute__ ((packed, aligned(1)))
>
> WARNING: __aligned(size) is preferred over
> __attribute__((aligned(size)))
> #14: FILE: drivers/net/altera_tse.h:14:
> +#define __packed_1_    __attribute__ ((packed, aligned(1)))
>
> Signed-off-by: Thomas Chou <thomas@wytron.com.tw>
> Reviewed-by: Marek Vasut <marex@denx.de>
> Reviewed-by: Chin Liang See <clsee@altera.com>
> ---
>   drivers/net/altera_tse.h | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>

Applied to u-boot-nios.

> diff --git a/drivers/net/altera_tse.h b/drivers/net/altera_tse.h
> index a96351a..78ae369 100644
> --- a/drivers/net/altera_tse.h
> +++ b/drivers/net/altera_tse.h
> @@ -11,7 +11,7 @@
>   #ifndef _ALTERA_TSE_H_
>   #define _ALTERA_TSE_H_
>
> -#define __packed_1_    __attribute__ ((packed, aligned(1)))
> +#define __packed_1_    __packed __aligned(1)
>
>   /* SGDMA Stuff */
>   #define ALT_SGDMA_STATUS_BUSY_MSK			(0x00000010)
>

  parent reply	other threads:[~2015-11-06  1:32 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-04  9:12 [U-Boot] [PATCH 1/6] net: altera_tse: use data type u32 for regs and desc Thomas Chou
2015-11-04  9:12 ` [U-Boot] [PATCH 2/6] net: altera_tse: fix packed and aligned attribute Thomas Chou
2015-11-04 16:06   ` Chin Liang See
2015-11-04  9:12 ` [U-Boot] [PATCH 3/6] net: altera_tse: fix CamelCase Thomas Chou
2015-11-04 16:17   ` Chin Liang See
2015-11-05 13:30     ` Thomas Chou
2015-11-04  9:12 ` [U-Boot] [PATCH 4/6] net: altera_tse: remove the useless parenthesis Thomas Chou
2015-11-04 16:18   ` Chin Liang See
2015-11-04  9:12 ` [U-Boot] [PATCH 5/6] net: altera_tse: remove unused macro Thomas Chou
2015-11-04 16:20   ` Chin Liang See
2015-11-04  9:12 ` [U-Boot] [PATCH 6/6] net: altera_tse: use BIT macro Thomas Chou
2015-11-04 13:51   ` Marek Vasut
2015-11-04 16:22   ` Chin Liang See
2015-11-04 16:46     ` Jagan Teki
2015-11-04 16:05 ` [U-Boot] [PATCH 1/6] net: altera_tse: use data type u32 for regs and desc Chin Liang See
2015-11-05 12:54 ` [U-Boot] [PATCH v2 1/5] net: altera_tse: remove unused macro and regs def Thomas Chou
2015-11-05 12:54   ` [U-Boot] [PATCH v2 2/5] net: altera_tse: use data type u32 for regs and desc Thomas Chou
2015-11-05 22:09     ` Joe Hershberger
2015-11-06  1:31     ` Thomas Chou
2015-11-05 12:54   ` [U-Boot] [PATCH v2 3/5] net: altera_tse: fix packed and aligned attribute Thomas Chou
2015-11-05 22:09     ` Joe Hershberger
2015-11-06  1:32     ` Thomas Chou [this message]
2015-11-05 12:54   ` [U-Boot] [PATCH v2 4/5] net: altera_tse: remove the useless parenthesis Thomas Chou
2015-11-05 22:09     ` Joe Hershberger
2015-11-06  1:32     ` Thomas Chou
2015-11-05 12:54   ` [U-Boot] [PATCH v2 5/5] net: altera_tse: use BIT macro Thomas Chou
2015-11-05 22:09     ` Joe Hershberger
2015-11-06  1:32     ` Thomas Chou
2015-11-05 22:08   ` [U-Boot] [PATCH v2 1/5] net: altera_tse: remove unused macro and regs def Joe Hershberger
2015-11-06  1:31   ` Thomas Chou

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=563C0314.4010109@wytron.com.tw \
    --to=thomas@wytron.com.tw \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox