public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Thomas Chou <thomas@wytron.com.tw>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 01/10] dm: timer: Fix several nits
Date: Fri, 6 Nov 2015 14:59:16 +0800	[thread overview]
Message-ID: <563C4FC4.5090802@wytron.com.tw> (raw)
In-Reply-To: <1446732171-7439-2-git-send-email-bmeng.cn@gmail.com>

Hi Bin,

On 2015?11?05? 22:02, Bin Meng wrote:
> This changes 'Timer' to 'timer' at several places.
>
> Signed-off-by: Bin Meng <bmeng.cn@gmail.com>
> ---
>
>   drivers/timer/Kconfig        | 10 +++++-----
>   drivers/timer/timer-uclass.c |  4 ++--
>   include/timer.h              | 11 ++++++-----
>   3 files changed, 13 insertions(+), 12 deletions(-)
>
> diff --git a/drivers/timer/Kconfig b/drivers/timer/Kconfig
> index 97c4128..895de38 100644
> --- a/drivers/timer/Kconfig
> +++ b/drivers/timer/Kconfig
> @@ -1,19 +1,19 @@
>   menu "Timer Support"
>
>   config TIMER
> -	bool "Enable Driver Model for Timer drivers"
> +	bool "Enable driver model for timer drivers"
>   	depends on DM
>   	help
> -	  Enable driver model for Timer access. It uses the same API as
> -	  lib/time.c. But now implemented by the uclass. The first timer
> +	  Enable driver model for timer access. It uses the same API as
> +	  lib/time.c, but now implemented by the uclass. The first timer
>   	  will be used. The timer is usually a 32 bits free-running up
>   	  counter. There may be no real tick, and no timer interrupt.
>
>   config ALTERA_TIMER
> -	bool "Altera Timer support"
> +	bool "Altera timer support"
>   	depends on TIMER
>   	help
> -	  Select this to enable an timer for Altera devices. Please find
> +	  Select this to enable a timer for Altera devices. Please find
>   	  details on the "Embedded Peripherals IP User Guide" of Altera.
>
>   endmenu
> diff --git a/drivers/timer/timer-uclass.c b/drivers/timer/timer-uclass.c
> index 12aee5b..82c6897 100644
> --- a/drivers/timer/timer-uclass.c
> +++ b/drivers/timer/timer-uclass.c
> @@ -10,10 +10,10 @@
>   #include <timer.h>
>
>   /*
> - * Implement a Timer uclass to work with lib/time.c. The timer is usually
> + * Implement a timer uclass to work with lib/time.c. The timer is usually
>    * a 32 bits free-running up counter. The get_rate() method is used to get
>    * the input clock frequency of the timer. The get_count() method is used
> - * get the current 32 bits count value. If the hardware is counting down,
> + * to get the current 32 bits count value. If the hardware is counting down,
>    * the value should be inversed inside the method. There may be no real
>    * tick, and no timer interrupt.
>    */
> diff --git a/include/timer.h b/include/timer.h
> index cdf385d..ed5c685 100644
> --- a/include/timer.h
> +++ b/include/timer.h
> @@ -10,30 +10,31 @@
>   /*
>    * Get the current timer count
>    *
> - * @dev: The Timer device
> + * @dev: The timer device
>    * @count: pointer that returns the current timer count
>    * @return: 0 if OK, -ve on error
>    */
>   int timer_get_count(struct udevice *dev, unsigned long *count);
> +
>   /*
>    * Get the timer input clock frequency
>    *
> - * @dev: The Timer device
> + * @dev: The timer device
>    * @return: the timer input clock frequency
>    */
>   unsigned long timer_get_rate(struct udevice *dev);
>
>   /*
> - * struct timer_ops - Driver model Timer operations
> + * struct timer_ops - Driver model timer operations
>    *
> - * The uclass interface is implemented by all Timer devices which use
> + * The uclass interface is implemented by all timer devices which use
>    * driver model.
>    */
>   struct timer_ops {
>   	/*
>   	 * Get the current timer count
>   	 *
> -	 * @dev: The Timer device
> +	 * @dev: The timer device
>   	 * @count: pointer that returns the current timer count
>   	 * @return: 0 if OK, -ve on error
>   	 */
>

Thanks. Might need rebase after nios2 timer cleaned up and sandbox timer 
added. Otherwise,

Ack-by: Thomas Chou <thomas@wytron.com.tw>

  reply	other threads:[~2015-11-06  6:59 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-05 14:02 [U-Boot] [PATCH 00/10] dm: timer: x86: 64-bit counter support and tsc timer dm conversion Bin Meng
2015-11-05 14:02 ` [U-Boot] [PATCH 01/10] dm: timer: Fix several nits Bin Meng
2015-11-06  6:59   ` Thomas Chou [this message]
2015-11-06 12:06     ` Simon Glass
2015-11-05 14:02 ` [U-Boot] [PATCH 02/10] dm: timer: Implement pre_probe() Bin Meng
2015-11-06  7:00   ` Thomas Chou
2015-11-06 12:08     ` Simon Glass
2015-11-05 14:02 ` [U-Boot] [PATCH 03/10] timer: altera: Remove the codes to get clock frequency Bin Meng
2015-11-06  7:01   ` Thomas Chou
2015-11-06 12:08     ` Simon Glass
2015-11-05 14:02 ` [U-Boot] [PATCH 04/10] dm: timer: Support 64-bit counter Bin Meng
2015-11-06  7:14   ` Thomas Chou
2015-11-06 14:35     ` Bin Meng
2015-11-06 22:40       ` Thomas Chou
2015-11-10  2:46         ` Bin Meng
2015-11-05 14:02 ` [U-Boot] [PATCH 05/10] x86: Reomve MIN_PORT80_KCLOCKS_DELAY Bin Meng
2015-11-06 12:08   ` Simon Glass
2015-11-05 14:02 ` [U-Boot] [PATCH 06/10] x86: tsc: Use notrace from <linux/compiler.h> Bin Meng
2015-11-06 12:08   ` Simon Glass
2015-11-05 14:02 ` [U-Boot] [PATCH 07/10] x86: tsc: Add driver model timer support Bin Meng
2015-11-06 12:08   ` Simon Glass
2015-11-05 14:02 ` [U-Boot] [PATCH 08/10] x86: Convert to use driver model timer Bin Meng
2015-11-06 12:08   ` Simon Glass
2015-11-06 14:28     ` Bin Meng
2015-11-06 23:58       ` Simon Glass
2015-11-05 14:02 ` [U-Boot] [PATCH 09/10] x86: tsc: Remove legacy timer codes Bin Meng
2015-11-06 12:08   ` Simon Glass
2015-11-05 14:02 ` [U-Boot] [PATCH 10/10] x86: tsc: Move tsc_timer.c to drivers/timer Bin Meng
2015-11-06 12:08   ` Simon Glass

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=563C4FC4.5090802@wytron.com.tw \
    --to=thomas@wytron.com.tw \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox