public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Stefan Roese <sr@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] dm: core: Kconfig: set OF_TRANSLATE default value to n
Date: Fri, 6 Nov 2015 13:19:44 +0100	[thread overview]
Message-ID: <563C9AE0.9000904@denx.de> (raw)
In-Reply-To: <CAPnjgZ2C9qLPOyKspwOgez-rDtjykz=uDA+5d2CU+rb_0N0SgQ@mail.gmail.com>

+Stephan Warren & Thomas Chou

On 06.11.2015 13:08, Simon Glass wrote:
> +Stefan
>
> Hi Mugunthan,
>
> On 4 November 2015 at 07:25, Mugunthan V N <mugunthanvnm@ti.com> wrote:
>> Based on the OF_TRANSLATE Kconfig description, this is required
>> only on platforms with complex "ranges" in the DT nodes. For
>> simpler platforms using SIMPLE_BUS should be sufficient. Since
>> this a set to default y, simple bus is never used in any
>> platform. So make the default value as "n" and enable
>> OF_TRANSLATE only on required platform.
>
> How do you know it is not used? This is surprising because Stefan
> presumably added it to fix something.

I assume Mugunthan meant, that simple bus is never used. This
is not quite correct, as its at least used per default in the
SPL (because of size reasons).

And yes, this translation via fdt_translate_address() is needed.
At least for some platforms, like mvebu & nios2 (IIRC). Stephen
also made some quite striking comments about this a few weeks
ago. And I really think that we should make use of this function
per default. Platforms that know for sure that they don't need
this functionality can always disable it selectively.

Mugunthan, why do you want to disable this functionality? Does
it cause problems on your platform? If yes, which ones?

Thanks,
Stefan

  reply	other threads:[~2015-11-06 12:19 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-04 14:25 [U-Boot] [PATCH] dm: core: Kconfig: set OF_TRANSLATE default value to n Mugunthan V N
2015-11-06 12:08 ` Simon Glass
2015-11-06 12:19   ` Stefan Roese [this message]
2015-11-06 15:41     ` Stephen Warren
2015-11-12  9:38       ` Mugunthan V N

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=563C9AE0.9000904@denx.de \
    --to=sr@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox