From: Mugunthan V N <mugunthanvnm@ti.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v2 10/16] drivers: mtd: spi: sf_probe: add compatible for spansion spi flash
Date: Thu, 12 Nov 2015 14:42:41 +0530 [thread overview]
Message-ID: <56445809.6020504@ti.com> (raw)
In-Reply-To: <CAPnjgZ1wJ90e2o61BOZJaDE6=zPik9FG=Ung4UcN6sNkNy8C-A@mail.gmail.com>
On Friday 06 November 2015 05:37 PM, Simon Glass wrote:
> Hi Mugunthan,
>
> On 4 November 2015 at 01:16, Mugunthan V N <mugunthanvnm@ti.com> wrote:
>> Add compatible for spansion 32MiB spi flash s25fl256s1.
>>
>> Signed-off-by: Mugunthan V N <mugunthanvnm@ti.com>
>> ---
>> drivers/mtd/spi/sf_probe.c | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/mtd/spi/sf_probe.c b/drivers/mtd/spi/sf_probe.c
>> index c000c53..9cfa9b6 100644
>> --- a/drivers/mtd/spi/sf_probe.c
>> +++ b/drivers/mtd/spi/sf_probe.c
>> @@ -502,6 +502,7 @@ static const struct dm_spi_flash_ops spi_flash_std_ops = {
>>
>> static const struct udevice_id spi_flash_std_ids[] = {
>> { .compatible = "spi-flash" },
>> + { .compatible = "s25fl256s1" },
>
> Instead, is it possible to add "spi-flash" to the list of compatible
> strings in your device tree?
>
The compatible "spi-flash" is not defined/documented in kernel and
compatible "s25fl256s1" is already documented and present in dt files.
So it will be good to follow the same dt compatibles in U-Boot so that
future merge/sync will be easier.
Regards
Mugunthan V N
next prev parent reply other threads:[~2015-11-12 9:12 UTC|newest]
Thread overview: 57+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-04 8:16 [U-Boot] [PATCH v2 00/16] device model bring-up of ti-qspi on dra72, dra74 and am437x-sk evm Mugunthan V N
2015-11-04 8:16 ` [U-Boot] [PATCH v2 01/16] drivers: spi: ti_qspi: do not hard code chip select for memory map configuration Mugunthan V N
2015-11-06 12:07 ` Simon Glass
2015-11-08 13:31 ` Tom Rini
2015-11-17 6:13 ` Jagan Teki
2015-11-04 8:16 ` [U-Boot] [PATCH v2 02/16] drivers: spi:ti_qspi: change ti_qspi_slave to ti_qspi_priv for driver model conversion Mugunthan V N
2015-11-06 12:07 ` Simon Glass
2015-11-08 13:31 ` Tom Rini
2015-11-17 6:14 ` Jagan Teki
2015-11-04 8:16 ` [U-Boot] [PATCH v2 03/16] drivers: spi: ti_qspi: prepare driver for DM conversion Mugunthan V N
2015-11-06 12:07 ` Simon Glass
2015-11-17 7:50 ` Mugunthan V N
2015-11-17 6:21 ` Jagan Teki
2015-11-17 7:53 ` Mugunthan V N
2015-11-18 15:54 ` Mugunthan V N
2015-11-04 8:16 ` [U-Boot] [PATCH v2 04/16] dm: core: Add a new api to get indexed device address Mugunthan V N
2015-11-06 12:07 ` Simon Glass
2015-11-17 7:55 ` Mugunthan V N
2015-11-04 8:16 ` [U-Boot] [PATCH v2 05/16] spi: Add support for dual and quad mode Mugunthan V N
2015-11-08 13:31 ` Tom Rini
2015-11-17 6:29 ` Jagan Teki
2015-11-04 8:16 ` [U-Boot] [PATCH v2 06/16] dra7xx_evm: qspi: do not define DM_SPI and DM_SPI_FLASH for spl Mugunthan V N
2015-11-06 12:07 ` Simon Glass
2015-11-12 9:15 ` Mugunthan V N
2015-11-04 8:16 ` [U-Boot] [PATCH v2 07/16] dts: dra7: add spi alias for qspi Mugunthan V N
2015-11-08 13:31 ` Tom Rini
2015-11-04 8:16 ` [U-Boot] [PATCH v2 08/16] drivers: spi: ti_qspi: convert driver to adopt device driver model Mugunthan V N
2015-11-06 12:07 ` Simon Glass
2015-11-08 13:31 ` Tom Rini
2015-11-04 8:16 ` [U-Boot] [PATCH v2 09/16] arm: dts: dra7: add qspi register maps for memory map and control module Mugunthan V N
2015-11-08 13:31 ` Tom Rini
2015-11-12 9:03 ` Mugunthan V N
2015-11-12 12:47 ` Tom Rini
2015-11-14 7:31 ` Mugunthan V N
2015-11-16 2:13 ` Tom Rini
2015-11-17 7:59 ` Mugunthan V N
2015-11-04 8:16 ` [U-Boot] [PATCH v2 10/16] drivers: mtd: spi: sf_probe: add compatible for spansion spi flash Mugunthan V N
2015-11-06 12:07 ` Simon Glass
2015-11-12 9:12 ` Mugunthan V N [this message]
2015-11-12 12:48 ` Tom Rini
2015-11-16 21:08 ` Simon Glass
2015-11-17 8:05 ` Mugunthan V N
2015-11-04 8:16 ` [U-Boot] [PATCH v2 11/16] drivers: mtd: spi: sf_probe: add compatible for Macronix " Mugunthan V N
2015-11-06 12:07 ` Simon Glass
2015-11-04 8:16 ` [U-Boot] [PATCH v2 12/16] defconfig: dra72_evm: enable spi driver model Mugunthan V N
2015-11-08 13:32 ` Tom Rini
2015-11-04 8:16 ` [U-Boot] [PATCH v2 13/16] defconfig: dra74_evm: " Mugunthan V N
2015-11-08 13:32 ` Tom Rini
2015-11-04 8:16 ` [U-Boot] [PATCH v2 14/16] am43xx_evm: qspi: do not define DM_SPI and DM_SPI_FLASH for spl Mugunthan V N
2015-11-06 12:07 ` Simon Glass
2015-11-12 9:15 ` Mugunthan V N
2015-11-04 8:16 ` [U-Boot] [PATCH v2 15/16] arm: dts: am4372: add qspi register maps for memory map Mugunthan V N
2015-11-08 13:32 ` Tom Rini
2015-11-12 9:17 ` Mugunthan V N
2015-11-04 8:16 ` [U-Boot] [PATCH v2 16/16] defconfig: am437x_sk_evm: enable spi driver model Mugunthan V N
2015-11-08 13:32 ` Tom Rini
2015-11-17 9:18 ` Jagan Teki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56445809.6020504@ti.com \
--to=mugunthanvnm@ti.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox