From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mugunthan V N Date: Thu, 12 Nov 2015 14:42:41 +0530 Subject: [U-Boot] [PATCH v2 10/16] drivers: mtd: spi: sf_probe: add compatible for spansion spi flash In-Reply-To: References: <1446624984-11033-1-git-send-email-mugunthanvnm@ti.com> <1446624984-11033-11-git-send-email-mugunthanvnm@ti.com> Message-ID: <56445809.6020504@ti.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Friday 06 November 2015 05:37 PM, Simon Glass wrote: > Hi Mugunthan, > > On 4 November 2015 at 01:16, Mugunthan V N wrote: >> Add compatible for spansion 32MiB spi flash s25fl256s1. >> >> Signed-off-by: Mugunthan V N >> --- >> drivers/mtd/spi/sf_probe.c | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/drivers/mtd/spi/sf_probe.c b/drivers/mtd/spi/sf_probe.c >> index c000c53..9cfa9b6 100644 >> --- a/drivers/mtd/spi/sf_probe.c >> +++ b/drivers/mtd/spi/sf_probe.c >> @@ -502,6 +502,7 @@ static const struct dm_spi_flash_ops spi_flash_std_ops = { >> >> static const struct udevice_id spi_flash_std_ids[] = { >> { .compatible = "spi-flash" }, >> + { .compatible = "s25fl256s1" }, > > Instead, is it possible to add "spi-flash" to the list of compatible > strings in your device tree? > The compatible "spi-flash" is not defined/documented in kernel and compatible "s25fl256s1" is already documented and present in dt files. So it will be good to follow the same dt compatibles in U-Boot so that future merge/sync will be easier. Regards Mugunthan V N