From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Warren Date: Thu, 12 Nov 2015 16:00:45 -0700 Subject: [U-Boot] [PATCH] arc: add stubs for map_physmem() and unmap_physmem() In-Reply-To: <1447365381-16342-1-git-send-email-abrodkin@synopsys.com> References: <1447365381-16342-1-git-send-email-abrodkin@synopsys.com> Message-ID: <56451A1D.3080104@wwwdotorg.org> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On 11/12/2015 02:56 PM, Alexey Brodkin wrote: > Up until now there was no need in those stubs. > > But since following commit compilation of U-Boot on ARC is broken: > commit 7861204c9af7fec1ea9b41541c272516235a6c93 > itest: make memory access work under sandbox > ... > That's because CMD_ITEST is enabled by default in common/Kconfig and now > map_physmem()/unmap_physmem() is used there. > > So this patch adds missing stubs for ARC. This looks OK, but rather than cut/pasting this exact same code yet another time, why not create e.g. include/io-base.h that contains this, and share it amongst all architectures?