public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Thomas Chou <thomas@wytron.com.tw>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v2] Fix board init code to use a valid C runtime environment
Date: Fri, 13 Nov 2015 16:20:39 +0800	[thread overview]
Message-ID: <56459D57.6060203@wytron.com.tw> (raw)
In-Reply-To: <20151113074143.3f455341@lilith>

Hi Albert,

On 2015?11?13? 14:41, Albert ARIBAUD wrote:
> Hello Thomas,
>
> On Thu, 12 Nov 2015 13:59:28 +0800, Thomas Chou <thomas@wytron.com.tw>
> wrote:
>> Hi Albert,
>
>> -	/* Update stack- and frame-pointers */
>> -	mov	sp, r2
>> -	mov	fp, sp
>
> Just a sec here on second thought.
>
> I understand the 'mov sp, r2' must be removed as it is replaced by a
> 'sub sp, sp, r2' a few lines earlier.
>
> But doesn't the 'mov fp, sp' need to remain? Without it, fp is not set
> any more, is it?
>

Yes, the 'mov fp, sp' need to remain. I forgot to add them.

Best regards,
Thomas

  reply	other threads:[~2015-11-13  8:20 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-10 18:30 [U-Boot] [PATCH v2] Fix board init code to use a valid C runtime environment Albert ARIBAUD
2015-11-11  8:52 ` Albert ARIBAUD
2015-11-12  5:59 ` Thomas Chou
2015-11-12  7:17   ` Albert ARIBAUD
2015-11-12  8:28     ` Thomas Chou
2015-11-12 10:23       ` Albert ARIBAUD
2015-11-13  6:41   ` Albert ARIBAUD
2015-11-13  8:20     ` Thomas Chou [this message]
2015-11-13  9:08 ` Bin Meng
2015-11-13 12:22   ` Albert ARIBAUD

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=56459D57.6060203@wytron.com.tw \
    --to=thomas@wytron.com.tw \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox