From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Chou <thomas@wytron.com.tw>
Date: Fri, 13 Nov 2015 16:20:39 +0800
Subject: [U-Boot] [PATCH v2] Fix board init code to use a valid C
 runtime environment
In-Reply-To: <20151113074143.3f455341@lilith>
References: <1447180247-29704-1-git-send-email-albert.u.boot@aribaud.net>
 <56442AC0.2030306@wytron.com.tw> <20151113074143.3f455341@lilith>
Message-ID: <56459D57.6060203@wytron.com.tw>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Hi Albert,

On 2015?11?13? 14:41, Albert ARIBAUD wrote:
> Hello Thomas,
>
> On Thu, 12 Nov 2015 13:59:28 +0800, Thomas Chou <thomas@wytron.com.tw>
> wrote:
>> Hi Albert,
>
>> -	/* Update stack- and frame-pointers */
>> -	mov	sp, r2
>> -	mov	fp, sp
>
> Just a sec here on second thought.
>
> I understand the 'mov sp, r2' must be removed as it is replaced by a
> 'sub sp, sp, r2' a few lines earlier.
>
> But doesn't the 'mov fp, sp' need to remain? Without it, fp is not set
> any more, is it?
>

Yes, the 'mov fp, sp' need to remain. I forgot to add them.

Best regards,
Thomas