public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Heiko Schocher <hs@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 3/4] km/scripts: load fdt_bid_kwkey.dtb when working with tftp
Date: Mon, 16 Nov 2015 12:09:50 +0100	[thread overview]
Message-ID: <5649B97E.8020007@denx.de> (raw)
In-Reply-To: <1447427722-24450-4-git-send-email-valentin.longchamp@keymile.com>

Hello Valentin,

Am 13.11.2015 um 16:15 schrieb Valentin Longchamp:
> From: Holger Brunck <holger.brunck@keymile.com>
>
> When loading the dtb file via tftp we should load the one which matches
> boardId and hwKey and not a common one for the boardname. We have boards
> were different hwKeys are used and then we may load an incorrect dtb
> file. If no fdt_bid_kwkey.dtb file is not a fallback to boardname.dtb is used.
>
> Signed-off-by: Holger Brunck <holger.brunck@keymile.com>
> Signed-off-by: Tobias M?ller <Tobias.Mueller@keymile.com>
> Signed-off-by: Valentin Longchamp <valentin.longchamp@keymile.com>
> ---
>
>   board/keymile/scripts/develop-common.txt | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)


Reviewed-by: Heiko Schocher <hs@denx.de>

bye,
Heiko
>
> diff --git a/board/keymile/scripts/develop-common.txt b/board/keymile/scripts/develop-common.txt
> index a80812a..99a0589 100644
> --- a/board/keymile/scripts/develop-common.txt
> +++ b/board/keymile/scripts/develop-common.txt
> @@ -3,7 +3,7 @@ bootcmd=run ${subbootcmds}
>   configure=run set_uimage; km_setboardid && saveenv && reset
>   subbootcmds=tftpfdt tftpkernel nfsargs add_default boot
>   nfsargs=setenv bootargs root=/dev/nfs rw nfsroot=${serverip}:${toolchain}/${arch}
> -tftpfdt=if run set_fdthigh || test ${arch} != arm; then tftpboot ${fdt_addr_r} ${hostname}/${hostname}.dtb; else true; fi
> +tftpfdt=if run set_fdthigh || test ${arch} != arm; then if tftpboot ${fdt_addr_r} ${hostname}/fdt_0x${IVM_BoardId}_0x${IVM_HWKey}.dtb; then; else tftpboot ${fdt_addr_r} ${hostname}/${hostname}.dtb; fi; else true; fi
>   tftpkernel=tftpboot ${load_addr_r} ${hostname}/${uimage}
>   toolchain=/opt/eldk
>   rootfssize=0
>

-- 
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany

  reply	other threads:[~2015-11-16 11:09 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-13 15:15 [U-Boot] [PATCH 0/4] Keymile common changes Valentin Longchamp
2015-11-13 15:15 ` [U-Boot] [PATCH 1/4] km/common: stop u-boot only if someone press <SPACE> Valentin Longchamp
2015-11-16 11:08   ` Heiko Schocher
2015-11-18 22:35   ` [U-Boot] [U-Boot, " Tom Rini
2015-11-13 15:15 ` [U-Boot] [PATCH 2/4] km: update the boot script to check for a DTB Valentin Longchamp
2015-11-16 11:09   ` Heiko Schocher
2015-11-18 22:35   ` [U-Boot] [U-Boot, " Tom Rini
2015-11-13 15:15 ` [U-Boot] [PATCH 3/4] km/scripts: load fdt_bid_kwkey.dtb when working with tftp Valentin Longchamp
2015-11-16 11:09   ` Heiko Schocher [this message]
2015-11-18 22:35   ` [U-Boot] [U-Boot, " Tom Rini
2015-11-13 15:15 ` [U-Boot] [PATCH 4/4] km/scripts: search for kernel/DTBs at serverip:/PRODUCTNAME via TFTP in develop mode Valentin Longchamp
2015-11-16 11:10   ` Heiko Schocher
2015-11-18 22:36   ` [U-Boot] [U-Boot, " Tom Rini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5649B97E.8020007@denx.de \
    --to=hs@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox