public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Vignesh R <vigneshr@ti.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] QSPI XIP boot on am437x
Date: Mon, 16 Nov 2015 17:18:26 +0530	[thread overview]
Message-ID: <5649C28A.6060109@ti.com> (raw)
In-Reply-To: <20151116124601.1314481a@lilith>

Hi Albert,

On 11/16/2015 05:16 PM, Albert ARIBAUD wrote:
> Hello Vignesh,
> 

[...]

>>>>
>>>> Do you see any issues with above change?
>>>
>>> (1) So your s_init runs even before board_init_f_mem(), right?
>>>
>>> Your working fix seems to imply that as long as s_init() is run after
>>> board_init_f_mem (and any time before board_init_f) it will work. If
>>> so, then another, fix, preferable to the above, would be that the call
>>> to s_init be moved between those to board_init_f_mem and board_init_f.
>>> Can you test that?
>>
>> Yes, gd area gets initialized to 0 in board_init_f_mem(). Initializing
>> the console thereafter fixes the issue. There is nothing between call to
>> board_init_f_mem and board_init_f. board_init_f gets called right after
>> board_init_f_mem (in arch/arm/lib/crt0.S), therefore I thought of moved
>> in serial_init call to board_init_f as above.
> 
> Can you please submit a patch? Bugfixes are welcome even when the merge
> window is closed.
> 

Yeah, I will submit a patch shortly. Thanks!

-- 
Regards
Vignesh

      reply	other threads:[~2015-11-16 11:48 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-10  8:59 [U-Boot] QSPI XIP boot on am437x Vignesh R
2015-11-10 12:14 ` Albert ARIBAUD
2015-11-11  6:12   ` R, Vignesh
2015-11-11  7:15     ` Albert ARIBAUD
2015-11-11  9:03       ` Albert ARIBAUD
2015-11-13  5:52         ` Vignesh R
2015-11-13  6:28           ` Albert ARIBAUD
2015-11-16 10:30             ` Vignesh R
2015-11-16 11:46               ` Albert ARIBAUD
2015-11-16 11:48                 ` Vignesh R [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5649C28A.6060109@ti.com \
    --to=vigneshr@ti.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox