From mboxrd@z Thu Jan  1 00:00:00 1970
From: Stephen Warren <swarren@wwwdotorg.org>
Date: Wed, 18 Nov 2015 14:35:27 -0700
Subject: [U-Boot] [PATCH 14/25] dm: tegra: net: Convert tegra boards to
 driver model for Ethernet
In-Reply-To: <1447732444-30892-15-git-send-email-sjg@chromium.org>
References: <1447732444-30892-1-git-send-email-sjg@chromium.org>
 <1447732444-30892-15-git-send-email-sjg@chromium.org>
Message-ID: <564CEF1F.1080108@wwwdotorg.org>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

On 11/16/2015 08:53 PM, Simon Glass wrote:
> Adjust all Tegra boards to use driver model for Ethernet, now that the
> required drivers are converted.

> diff --git a/arch/arm/mach-tegra/Kconfig b/arch/arm/mach-tegra/Kconfig

> @@ -14,6 +14,7 @@ config TEGRA_ARMV7_COMMON
>   	select DM_GPIO
>   	select DM_PCI
>   	select DM_PCI_COMPAT
> +	select DM_ETH

This should be set for Tegra210 too. I suggest creating a "config 
TEGRA_COMMON" to contain all the shared settings, and making 
TEGRA_ARMV7_COMMON and TEGRA_ARMV8_COMMON (also new) select that.

> diff --git a/board/compulab/trimslice/trimslice.c b/board/compulab/trimslice/trimslice.c

> -#ifdef CONFIG_PCI
> -int board_eth_init(bd_t *bis)
> -{
> -	return pci_eth_init(bis);
> -}
> -#endif

Has the need to call this function already been removed by this point in 
the series. In other words, does each commit in this series compile and 
support using Ethernet? If not, anyone running "git bisect" is going to 
be very sad.