[U-Boot] [U-Boot,v3,09/13] ns16550: unify serial_tegra

Simon Glass
2015-12-03T21:43:56Z

Hi Stephen,

On 3 December 2015 at 14:33, Stephen Warren <swarren@wwwdotorg.org> wrote:
> On 11/22/2015 08:53 AM, Tom Rini wrote:
>>
>> On Thu, Nov 19, 2015 at 09:48:11PM +0800, Thomas Chou wrote:
>>
>>> Unify serial_tegra, and use the generic binding.
>>>
>>> Signed-off-by: Thomas Chou <thomas@wytron.com.tw>
>>> Reviewed-by: Tom Rini <trini@konsulko.com>
>>> Acked-by: Simon Glass <sjg@chromium.org>
>>
>>
>> Applied to u-boot/master, thanks!
>
>
> FYI, this patch causes at least Jetson TK1 to immediately reset at boot
> time. I imagine this affects all Tegra boards, at least those that use SPL
> or those that are ARMv7; my p2371-2180 Jetson TX1 ARMv8 board which doesn't
> use SPL seems to still work.
>
> I guess I'll see if I can pin-point the problem, unless you can spot an
> obvious typo or something like that.
>
> Reported-by: Kevin Hilman <khilman@linaro.org>
> (Bisected by me)

Unfortunately I didn't test this patch.

Things to check:
- for SPL, that the platform data is available somewhere
- clock-frequency and reg-shift are in the device tree

Regards,
Simon