[U-Boot] [PATCH v2 11/13] ns16550: zap CONFIG_NS16550_SERIAL

Bin Meng
2015-11-19T07:17:56Z

Hi Thomas,

On Wed, Nov 18, 2015 at 10:36 PM, Thomas Chou <thomas@wytron.com.tw> wrote:
> Hi Bin,
>
>
> On 2015?11?18? 22:09, Bin Meng wrote:
>>
>> Hi Thomas,
>>
>> On Wed, Nov 18, 2015 at 9:44 PM, Thomas Chou <thomas@wytron.com.tw> wrote:
>>>
>>> Zap CONFIG_NS16550_SERIAL, as the unification of ns16550 drivers
>>> is completed.
>>>
>>> Signed-off-by: Thomas Chou <thomas@wytron.com.tw>
>>> ---
>>> configs/efi-x86_defconfig | 1 -
>>> drivers/serial/Kconfig | 12 ------------
>>> drivers/serial/ns16550.c | 4 ----
>>> include/configs/am43xx_evm.h | 2 --
>>> include/configs/cm_t43.h | 1 -
>>> include/configs/mv-common.h | 4 ----
>>> include/configs/omap3_pandora.h | 1 -
>>> include/configs/sniper.h | 4 +---
>>> include/configs/sunxi-common.h | 4 +---
>>> include/configs/tb100.h | 1 -
>>> include/configs/tegra-common.h | 1 -
>>> include/configs/ti_am335x_common.h | 4 ----
>>> include/configs/ti_armv7_keystone2.h | 2 --
>>> include/configs/ti_omap3_common.h | 4 ----
>>> include/configs/ti_omap4_common.h | 2 --
>>> include/configs/ti_omap5_common.h | 2 --
>>> 16 files changed, 2 insertions(+), 47 deletions(-)
>>>
>>> diff --git a/configs/efi-x86_defconfig b/configs/efi-x86_defconfig
>>> index b1573df..904b564 100644
>>> --- a/configs/efi-x86_defconfig
>>> +++ b/configs/efi-x86_defconfig
>>> @@ -3,7 +3,6 @@ CONFIG_VENDOR_EFI=y
>>> CONFIG_DEFAULT_DEVICE_TREE="efi"
>>> CONFIG_TARGET_EFI=y
>>> CONFIG_TSC_CALIBRATION_BYPASS=y
>>> -# CONFIG_NS16550_SERIAL is not set
>>
>>
>> This line should not be removed.
>
>
> The CONFIG_NS16550_SERIAL is used only during the transition and it is
> removed now. It does not need this for efi serial to work.
>

Yes, I just checked patch#12 "ns16550: move CONFIG_SYS_NS16550 to
Kconfig" (a huge patchset) and found CONFIG_SYS_NS16550 is not on by
default for x86, so this line in efi-x86 can be removed. Previously I
was thinking the option is still on and if that's the case, this line
in efi-x86 should not be removed otherwise efi-x86 won't work.

> Thank you again for the review.
>
> Best regards,
> Thomas

Regards,
Bin