[U-Boot] [PATCH 01/12] debug_uart: restore ns16550 as default

Bin Meng
2015-11-18T00:51:27Z

Hi Thomas,

On Mon, Nov 16, 2015 at 10:36 PM, Thomas Chou <thomas@wytron.com.tw> wrote:
> Since commit 220e8021af96 ("nios2: convert altera_jtag_uart to
> driver model"), the default debug uart was changed. Most people
> use ns16550 UART, so restore it as default.
>
> Signed-off-by: Thomas Chou <thomas@wytron.com.tw>
> Reported-by: Ezequiel Garcia <ezequiel@vanguardiasur.com.ar>
> Reported-by: Ariel D'Alessandro <ariel@vanguardiasur.com.ar>
> ---
> drivers/serial/Kconfig | 14 +++++++-------
> 1 file changed, 7 insertions(+), 7 deletions(-)
>
> diff --git a/drivers/serial/Kconfig b/drivers/serial/Kconfig
> index d462244..9476a00 100644
> --- a/drivers/serial/Kconfig
> +++ b/drivers/serial/Kconfig
> @@ -54,6 +54,13 @@ choice
> prompt "Select which UART will provide the debug UART"
> depends on DEBUG_UART
>
> +config DEBUG_UART_NS16550
> + bool "ns16550"
> + help
> + Select this to enable a debug UART using the ns16550 driver. You
> + will need to provide parameters to make this work. The driver will
> + be available until the real driver model serial is running.

Can you please add a comment above this option saying that we should
keep DEBUG_UART_NS16550 the first one so that it shows as the default
in the kconfig? This is to give a hint to someone else in the future
who touches this file and avoid any further unwanted changes.

> +
> config DEBUG_UART_ALTERA_JTAGUART
> bool "Altera JTAG UART"
> help
> @@ -68,13 +75,6 @@ config DEBUG_UART_ALTERA_UART
> You will need to provide parameters to make this work. The driver will
> be available until the real driver model serial is running.
>
> -config DEBUG_UART_NS16550
> - bool "ns16550"
> - help
> - Select this to enable a debug UART using the ns16550 driver. You
> - will need to provide parameters to make this work. The driver will
> - be available until the real driver model serial is running.
> -
> config DEBUG_EFI_CONSOLE
> bool "EFI"
> depends on EFI_APP
> --

Regards,
Bin