From: Stephen Warren <swarren@wwwdotorg.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] pci: fix address range check in __pci_hose_phys_to_bus()
Date: Thu, 19 Nov 2015 09:40:49 -0700 [thread overview]
Message-ID: <564DFB91.6080906@wwwdotorg.org> (raw)
In-Reply-To: <1447855506-14584-1-git-send-email-marcel.ziswiler@toradex.com>
On 11/18/2015 07:05 AM, Marcel Ziswiler wrote:
> The address range check may overflow if the memory region is located at
> the top of the 32-bit address space. This can e.g. be seen on TK1 if
> using the E1000 gigabit Ethernet driver where start and size are both
> 0x80000000 leading to the following messages:
>
> Apalis TK1 # tftpboot $loadaddr test_file
> Using e1000#0 device
> TFTP from server 192.168.10.1; our IP address is 192.168.10.2
> Filename 'test_file'.
> Load address: 0x80408000
> Loading: pci_hose_phys_to_bus: invalid physical address
>
> This patch fixes this by changing the order of the addition vs.
> subtraction in the range check just like already done in
> __pci_hose_bus_to_phys().
Reviewed-by: Stephen Warren <swarren@nvidia.com>
next prev parent reply other threads:[~2015-11-19 16:40 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-18 14:05 [U-Boot] [PATCH] pci: fix address range check in __pci_hose_phys_to_bus() Marcel Ziswiler
2015-11-18 14:19 ` Bin Meng
2015-11-18 14:53 ` Ivan Mercier
2015-11-19 1:47 ` Bin Meng
2015-11-19 16:40 ` Stephen Warren [this message]
2015-11-19 20:05 ` Simon Glass
2015-11-23 22:44 ` [U-Boot] " Tom Rini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=564DFB91.6080906@wwwdotorg.org \
--to=swarren@wwwdotorg.org \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox