From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Warren Date: Thu, 19 Nov 2015 09:40:49 -0700 Subject: [U-Boot] [PATCH] pci: fix address range check in __pci_hose_phys_to_bus() In-Reply-To: <1447855506-14584-1-git-send-email-marcel.ziswiler@toradex.com> References: <1447855506-14584-1-git-send-email-marcel.ziswiler@toradex.com> Message-ID: <564DFB91.6080906@wwwdotorg.org> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On 11/18/2015 07:05 AM, Marcel Ziswiler wrote: > The address range check may overflow if the memory region is located at > the top of the 32-bit address space. This can e.g. be seen on TK1 if > using the E1000 gigabit Ethernet driver where start and size are both > 0x80000000 leading to the following messages: > > Apalis TK1 # tftpboot $loadaddr test_file > Using e1000#0 device > TFTP from server 192.168.10.1; our IP address is 192.168.10.2 > Filename 'test_file'. > Load address: 0x80408000 > Loading: pci_hose_phys_to_bus: invalid physical address > > This patch fixes this by changing the order of the addition vs. > subtraction in the range check just like already done in > __pci_hose_bus_to_phys(). Reviewed-by: Stephen Warren