public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Stefano Babic <sbabic@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] arm: mx6: Reduce SPL malloc pool size
Date: Fri, 20 Nov 2015 22:24:46 +0100	[thread overview]
Message-ID: <564F8F9E.4030708@denx.de> (raw)
In-Reply-To: <1448052204-4928-1-git-send-email-marex@denx.de>

On 20/11/2015 21:43, Marek Vasut wrote:
> Using 50 MiB malloc pool in SPL is nonsense. Since the caches are not
> enabled in SPL, it takes 2 seconds to init the pool and has no obvious
> benefit. Reduce the size to 1 MiB.

You're absolutely right ! Nice catch !

> 
> Signed-off-by: Marek Vasut <marex@denx.de>
> Cc: Stefano Babic <sbabic@denx.de>
> Cc: Tim Harvey <tharvey@gateworks.com>
> ---
>  include/configs/imx6_spl.h | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/include/configs/imx6_spl.h b/include/configs/imx6_spl.h
> index 1744f2c..43ce7fe 100644
> --- a/include/configs/imx6_spl.h
> +++ b/include/configs/imx6_spl.h
> @@ -63,15 +63,15 @@
>  
>  #if defined(CONFIG_MX6SX) || defined(CONFIG_MX6UL) || defined(CONFIG_MX6SL)
>  #define CONFIG_SPL_BSS_START_ADDR      0x88200000
> -#define CONFIG_SPL_BSS_MAX_SIZE        0x100000        /* 1 MB */
> +#define CONFIG_SPL_BSS_MAX_SIZE        0x100000		/* 1 MB */
>  #define CONFIG_SYS_SPL_MALLOC_START    0x88300000
> -#define CONFIG_SYS_SPL_MALLOC_SIZE     0x3200000       /* 50 MB */
> +#define CONFIG_SYS_SPL_MALLOC_SIZE     0x100000		/* 1 MB */
>  #define CONFIG_SYS_TEXT_BASE           0x87800000
>  #else
>  #define CONFIG_SPL_BSS_START_ADDR	0x18200000
>  #define CONFIG_SPL_BSS_MAX_SIZE		0x100000	/* 1 MB */
>  #define CONFIG_SYS_SPL_MALLOC_START	0x18300000
> -#define CONFIG_SYS_SPL_MALLOC_SIZE	0x3200000	/* 50 MB */
> +#define CONFIG_SYS_SPL_MALLOC_SIZE	0x100000	/* 1 MB */
>  #define CONFIG_SYS_TEXT_BASE		0x17800000
>  #endif
>  #endif
> 

Tested-by: Stefano Babic <sbabic@denx.de>

Best regards,
Stefano Babic

-- 
=====================================================================
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================

  reply	other threads:[~2015-11-20 21:24 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-20 20:43 [U-Boot] [PATCH] arm: mx6: Reduce SPL malloc pool size Marek Vasut
2015-11-20 21:24 ` Stefano Babic [this message]
2015-11-20 21:40 ` Tim Harvey
2015-11-25 10:40   ` Przemyslaw Marczak
2015-11-25 10:56     ` Marek Vasut
2015-11-25 12:00       ` Przemyslaw Marczak
2015-11-25 12:16         ` Marek Vasut
2015-11-25 13:15           ` Przemyslaw Marczak
2015-11-25 13:32             ` Marek Vasut
2015-11-30 18:56               ` Tim Harvey
2015-11-30 23:31                 ` Marek Vasut
2015-12-01 14:13                   ` Tim Harvey
2015-12-01 14:16                     ` Marek Vasut
2015-12-01 14:18                   ` Stefano Babic

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=564F8F9E.4030708@denx.de \
    --to=sbabic@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox