From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Chou Date: Sat, 21 Nov 2015 10:39:54 +0800 Subject: [U-Boot] [PATCH v3 05/13] ns16550: unify serial_ppc In-Reply-To: References: <1447684616-10297-1-git-send-email-thomas@wytron.com.tw> <1447940895-7763-1-git-send-email-thomas@wytron.com.tw> <1447940895-7763-6-git-send-email-thomas@wytron.com.tw> <564FB8A6.2090502@wytron.com.tw> Message-ID: <564FD97A.4070807@wytron.com.tw> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hi Simon, On 2015?11?21? 08:27, Simon Glass wrote: >> I moved it to a macro. >> #define CONFIG_SYS_NS16550_CLK get_serial_clock() > > Ah, we shouldn't do that with driver model. This should be in some > sort of clock driver. Perhaps we should leave this serial driver along > for now? I understand a clock driver should be used for driver model. But I would suggest that we use this get_serial_clock macro until the clock driver for powerpc is ready to get UART clock. This will help things moving forwards to driver model. Best regards, Thomas