From: Stephen Warren <swarren@wwwdotorg.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 2/2] usb: eth: add Realtek RTL8152B/RTL8153 driver
Date: Sun, 22 Nov 2015 10:12:35 -0700 [thread overview]
Message-ID: <5651F783.7040700@wwwdotorg.org> (raw)
In-Reply-To: <CANAwSgSbSf49e3Bh3x62CkJHtO97s-BEo421YE37dFB9r5jeJA@mail.gmail.com>
On 11/20/2015 09:10 PM, Anand Moon wrote:
...
> ?I have just patch the driver and enable the driver.
...
> After doing 'usb start' and 'usb reset'
>
> I have tested with ASIX88179 USB 3.0 Ethernet cable and the u-boot
> successfully detected the device.
> My fried also tested with RTL8152 USB 3.0 Ethernet cable and the u-boot
> successfully detected the device.
> But with this driver I am not able to detect the Ethernet USB3.0 RT8153-VB
> connected to the OdroidXU4 board.
...
> ?U-Boot 2015.10-25167-g439fcb9-dirty (Nov 21 2015 - 14:27:19 +1030) for
> ODROID-XU3
...
> ODROID-XU3 # usb start
...
> USB Ethernet device detected: 0xbda:0x8153
> Endpoints In 1 Out 2 Int 3
> Setup ERROR: address device command for slot 1.
> Unknown version 0x7cf0
> Unknown Device
> 0 Ethernet Device(s) found
Ted sent an off-list patch that might be related to this. Perhaps EHCI
has the same check? Try something like the following:
> From 0aca6ac3391a3579815dd06ad981c2c7de0d59f7 Mon Sep 17 00:00:00 2001
> From: Ted Chen <tedchen@realtek.com>
> Date: Fri, 20 Nov 2015 18:09:20 +0800
> Subject: [PATCH] usb: xhci: Fix vendor command error if the request type is
> USB_REQ_SET_ADDRESS or USB_REQ_SET_CONFIGURATION.
>
> Add a condition of set_address and set_configuration to check
> if the request is standardized.
>
> Signed-off-by: Ted Chen <tedchen@realtek.com>
> ---
> drivers/usb/host/xhci.c | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/usb/host/xhci.c b/drivers/usb/host/xhci.c
> index ca598aa..cb8a04b 100644
> --- a/drivers/usb/host/xhci.c
> +++ b/drivers/usb/host/xhci.c
> @@ -941,10 +941,12 @@ static int _xhci_submit_control_msg(struct usb_device *udev, unsigned long pipe,
> if (usb_pipedevice(pipe) == ctrl->rootdev)
> return xhci_submit_root(udev, pipe, buffer, setup);
>
> - if (setup->request == USB_REQ_SET_ADDRESS)
> + if (setup->request == USB_REQ_SET_ADDRESS &&
> + (setup->requesttype & USB_TYPE_MASK) == USB_TYPE_STANDARD)
> return xhci_address_device(udev, root_portnr);
>
> - if (setup->request == USB_REQ_SET_CONFIGURATION) {
> + if (setup->request == USB_REQ_SET_CONFIGURATION &&
> + (setup->requesttype & USB_TYPE_MASK) == USB_TYPE_STANDARD) {
> ret = xhci_set_configuration(udev);
> if (ret) {
> puts("Failed to configure xHCI endpoint\n");
> --
> 1.7.9.5
next prev parent reply other threads:[~2015-11-22 17:12 UTC|newest]
Thread overview: 64+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-13 16:03 [U-Boot] [PATCH 1/2] checkpatch: ignore request to use ether_addr_copy() Stephen Warren
2015-11-13 16:03 ` [U-Boot] [PATCH 2/2] usb: eth: add Realtek RTL8152B/RTL8153 driver Stephen Warren
2015-11-14 1:13 ` Marek Vasut
2015-11-16 17:32 ` Stephen Warren
2015-11-17 7:18 ` Ted
2015-11-17 8:04 ` Marek Vasut
2015-11-19 6:07 ` Anand Moon
2015-11-19 16:51 ` Stephen Warren
2015-11-19 17:00 ` Lukasz Majewski
2015-11-19 17:00 ` Marek Vasut
2015-11-19 10:58 ` Anand Moon
2015-11-19 11:12 ` Marek Vasut
2015-11-19 12:49 ` Anand Moon
2015-11-19 13:12 ` Marek Vasut
2015-11-20 17:35 ` Simon Glass
2015-11-20 17:38 ` Marek Vasut
2015-11-21 4:10 ` Anand Moon
2015-11-22 17:12 ` Stephen Warren [this message]
2015-11-22 19:25 ` Anand Moon
2015-11-21 7:27 ` Stephen Warren
2015-11-21 16:50 ` Simon Glass
2015-11-22 17:09 ` Stephen Warren
2015-11-23 3:09 ` Simon Glass
2015-11-23 17:16 ` Stephen Warren
2015-11-25 5:30 ` [U-Boot] [PATCH v2 " Ted Chen
2015-11-25 9:09 ` Anand Moon
2015-11-26 16:58 ` Marek Vasut
2015-11-30 22:07 ` Joe Hershberger
2015-12-01 11:24 ` [U-Boot] [PATCH v3 " Ted Chen
2015-12-01 15:10 ` Marek Vasut
2015-12-01 16:31 ` Stephen Warren
2015-12-01 17:11 ` Marek Vasut
2015-12-01 16:32 ` Simon Glass
2016-01-13 18:27 ` Stephen Warren
2016-01-14 4:37 ` [U-Boot] [PATCH v4 2/2] usb: eth: add Realtek RTL8152B/RTL8153 DRIVER Ted Chen
2016-01-14 4:42 ` Marek Vasut
2016-01-14 5:22 ` Ted Chen
2016-01-14 5:37 ` Marek Vasut
2016-01-20 6:24 ` [U-Boot] [PATCH v5 " Ted Chen
2016-01-20 13:08 ` Marek Vasut
2016-01-20 16:52 ` Stephen Warren
2016-01-20 20:10 ` Anand Moon
2016-01-20 20:34 ` Marek Vasut
2016-01-21 8:55 ` Anand Moon
2016-01-21 10:12 ` Marek Vasut
2016-01-22 19:50 ` Joe Hershberger
2016-01-22 20:00 ` Marek Vasut
2016-01-22 20:41 ` Joe Hershberger
2016-01-23 0:42 ` Marek Vasut
2016-01-23 15:23 ` Marek Vasut
2016-01-23 18:55 ` Anand Moon
2016-01-23 19:38 ` Marek Vasut
2016-01-25 3:42 ` Ted
2016-01-25 3:47 ` Marek Vasut
2015-11-14 0:56 ` [U-Boot] [PATCH 1/2] checkpatch: ignore request to use ether_addr_copy() Marek Vasut
2015-11-23 23:36 ` Joe Hershberger
2015-12-15 23:34 ` Stephen Warren
2015-12-15 23:41 ` Joe Hershberger
[not found] ` <56969621.30204@wwwdotorg.org>
2016-01-20 20:47 ` Stephen Warren
2016-01-20 21:00 ` Tom Rini
2016-01-20 21:04 ` Stephen Warren
2016-01-21 1:22 ` Tom Rini
2016-01-21 4:09 ` Joe Hershberger
2016-01-25 21:28 ` [U-Boot] [U-Boot, " Tom Rini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5651F783.7040700@wwwdotorg.org \
--to=swarren@wwwdotorg.org \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox