public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: "Andreas Bießmann" <andreas.devel@googlemail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v2 2/5] arm: at91/spl: matrix: remove matrix write protection code
Date: Mon, 23 Nov 2015 17:48:39 +0100	[thread overview]
Message-ID: <56534367.6040803@googlemail.com> (raw)
In-Reply-To: <1446712673-9079-3-git-send-email-wenyou.yang@atmel.com>

On 05.11.15 09:37, Wenyou Yang wrote:
> On processor reset, the matrix write protection is disabled,
> so no need to disable/enable write protection when writing
> the matrix registers.
> 
> Signed-off-by: Wenyou Yang <wenyou.yang@atmel.com>

Reviewed-by: Andreas Bie?mann <andreas.devel@googlemail.com>

> ---
> 
> Changes in v2: None
> 
>  arch/arm/mach-at91/matrix.c |    8 --------
>  1 file changed, 8 deletions(-)
> 
> diff --git a/arch/arm/mach-at91/matrix.c b/arch/arm/mach-at91/matrix.c
> index cf36386..452a6b9 100644
> --- a/arch/arm/mach-at91/matrix.c
> +++ b/arch/arm/mach-at91/matrix.c
> @@ -15,10 +15,6 @@ void matrix_init(void)
>  	struct atmel_matrix *h32mx = (struct atmel_matrix *)ATMEL_BASE_MATRIX1;
>  	int i;
>  
> -	/* Disable the write protect */
> -	writel(ATMEL_MATRIX_WPMR_WPKEY & ~ATMEL_MATRIX_WPMR_WPEN, &h64mx->wpmr);
> -	writel(ATMEL_MATRIX_WPMR_WPKEY & ~ATMEL_MATRIX_WPMR_WPEN, &h32mx->wpmr);
> -
>  	/* DDR port 1 ~ poart 7, slave number is: 4 ~ 10 */
>  	for (i = 4; i <= 10; i++) {
>  		writel(0x000f0f0f, &h64mx->ssr[i]);
> @@ -44,8 +40,4 @@ void matrix_init(void)
>  	/* Configure Programmable Security peripherals on matrix 32 */
>  	writel(readl(&h32mx->spselr[0]) | 0xFFC00000, &h32mx->spselr[0]);
>  	writel(readl(&h32mx->spselr[1]) | 0x60E3FFFF, &h32mx->spselr[1]);
> -
> -	/* Enable the write protect */
> -	writel(ATMEL_MATRIX_WPMR_WPKEY | ATMEL_MATRIX_WPMR_WPEN, &h64mx->wpmr);
> -	writel(ATMEL_MATRIX_WPMR_WPKEY | ATMEL_MATRIX_WPMR_WPEN, &h32mx->wpmr);
>  }
> 

  reply	other threads:[~2015-11-23 16:48 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-05  8:37 [U-Boot] [PATCH v2 0/5] arm: at91/spl: make matrix and saic redirect sharing with others Wenyou Yang
2015-11-05  8:37 ` [U-Boot] [PATCH v2 1/5] arm: at91/spl: matrix: move matrix init to separate file Wenyou Yang
2015-11-23 16:43   ` Andreas Bießmann
2015-11-30 21:28   ` [U-Boot] [U-Boot, v2, " Andreas Bießmann
2015-12-01  1:41     ` Yang, Wenyou
2015-11-05  8:37 ` [U-Boot] [PATCH v2 2/5] arm: at91/spl: matrix: remove matrix write protection code Wenyou Yang
2015-11-23 16:48   ` Andreas Bießmann [this message]
2015-11-30 21:28   ` [U-Boot] [U-Boot, v2, " Andreas Bießmann
2015-11-05  8:37 ` [U-Boot] [PATCH v2 3/5] arm: at91/spl: matrix: remove security peripheral select code Wenyou Yang
2015-11-23 16:49   ` Andreas Bießmann
2015-11-30 21:29   ` [U-Boot] [U-Boot, v2, " Andreas Bießmann
2015-11-05  8:37 ` [U-Boot] [PATCH v2 4/5] arm: at91/spl: matrix: use matrix slave id macros Wenyou Yang
2015-11-23 16:53   ` Andreas Bießmann
2015-11-30 21:29   ` [U-Boot] [U-Boot, v2, " Andreas Bießmann
2015-11-05  8:37 ` [U-Boot] [PATCH v2 5/5] arm: at91/spl: atmel_sfr: move saic redirect to separate file Wenyou Yang
2015-11-27 21:06   ` Andreas Bießmann
2015-11-30 21:29   ` [U-Boot] [U-Boot, v2, " Andreas Bießmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=56534367.6040803@googlemail.com \
    --to=andreas.devel@googlemail.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox